* bitmap: Remove unused function declaration
@ 2020-11-16 3:17 Ma, Jianpeng
2020-11-16 3:59 ` Yury Norov
0 siblings, 1 reply; 3+ messages in thread
From: Ma, Jianpeng @ 2020-11-16 3:17 UTC (permalink / raw)
To: yury.norov; +Cc: linux-kernel
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
---
include/linux/bitmap.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index 99058eb81042..6f08965c69a5 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -126,8 +126,6 @@ extern void bitmap_free(const unsigned long *bitmap);
* lib/bitmap.c provides these functions:
*/
-extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
-extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
extern int __bitmap_equal(const unsigned long *bitmap1,
const unsigned long *bitmap2, unsigned int nbits);
extern bool __pure __bitmap_or_equal(const unsigned long *src1,
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bitmap: Remove unused function declaration
2020-11-16 3:17 bitmap: Remove unused function declaration Ma, Jianpeng
@ 2020-11-16 3:59 ` Yury Norov
2020-11-16 10:00 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Yury Norov @ 2020-11-16 3:59 UTC (permalink / raw)
To: Ma, Jianpeng, Linux Kernel Mailing List
Cc: Andrew Morton, Rasmus Villemoes, Andy Shevchenko
(CC related people)
Since there is no actual implementation for them, there's , I think
it's safe (and better)
to remove the declarations. Thanks for the catch.
Acked-by: Yury Norov <yury.norov@gmail.com>
On Sun, Nov 15, 2020 at 7:17 PM Ma, Jianpeng <jianpeng.ma@intel.com> wrote:
>
> Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
> ---
> include/linux/bitmap.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index 99058eb81042..6f08965c69a5 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -126,8 +126,6 @@ extern void bitmap_free(const unsigned long *bitmap);
> * lib/bitmap.c provides these functions:
> */
>
> -extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
> -extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
> extern int __bitmap_equal(const unsigned long *bitmap1,
> const unsigned long *bitmap2, unsigned int nbits);
> extern bool __pure __bitmap_or_equal(const unsigned long *src1,
> --
> 2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bitmap: Remove unused function declaration
2020-11-16 3:59 ` Yury Norov
@ 2020-11-16 10:00 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-11-16 10:00 UTC (permalink / raw)
To: Yury Norov
Cc: Ma, Jianpeng, Linux Kernel Mailing List, Andrew Morton, Rasmus Villemoes
On Sun, Nov 15, 2020 at 07:59:37PM -0800, Yury Norov wrote:
> (CC related people)
>
> Since there is no actual implementation for them, there's , I think
> it's safe (and better)
> to remove the declarations. Thanks for the catch.
Fixes: 2afe27c718b6 ("lib/bitmap.c: bitmap_[empty,full]: remove code duplication")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Yury Norov <yury.norov@gmail.com>
>
> On Sun, Nov 15, 2020 at 7:17 PM Ma, Jianpeng <jianpeng.ma@intel.com> wrote:
> >
> > Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
> > ---
> > include/linux/bitmap.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> > index 99058eb81042..6f08965c69a5 100644
> > --- a/include/linux/bitmap.h
> > +++ b/include/linux/bitmap.h
> > @@ -126,8 +126,6 @@ extern void bitmap_free(const unsigned long *bitmap);
> > * lib/bitmap.c provides these functions:
> > */
> >
> > -extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
> > -extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
> > extern int __bitmap_equal(const unsigned long *bitmap1,
> > const unsigned long *bitmap2, unsigned int nbits);
> > extern bool __pure __bitmap_or_equal(const unsigned long *src1,
> > --
> > 2.28.0
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-16 10:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 3:17 bitmap: Remove unused function declaration Ma, Jianpeng
2020-11-16 3:59 ` Yury Norov
2020-11-16 10:00 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome