* [RESEND 00/42] Rid W=1 warnings from GPU (non-Radeon)
@ 2020-11-16 17:33 Lee Jones
2020-11-16 17:33 ` [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Lee Jones @ 2020-11-16 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Ajay Kumar, Akshu Agarwal, Alex Deucher, amd-gfx,
Ben Skeggs, Christian Koenig, Chris Zhong, Chun-Kuang Hu,
Daniel Vetter, David Airlie, David Francis, dri-devel,
Eric Anholt, Eunchul Kim, Fabio Estevam, freedreno,
Heiko Stübner, Huang Rui, Inki Dae, Jerome Brunet, Jie Qiu,
Jinyoung Jeon, Joonyoung Shim, Kalyan Thota, Kevin Hilman,
Krzysztof Kozlowski, Kyungmin Park, linaro-mm-sig, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-mediatek, linux-media,
linux-rockchip, linux-samsung-soc, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Mark Yao, Martin Blumenstingl,
Matthias Brugger, Maxime Ripard, Neil Armstrong, Nickey Yang,
Nirmoy Das, nouveau, NXP Linux Team, Pengutronix Kernel Team,
Philipp Zabel, Rob Clark, Russell King, Sandy Huang, Sangmin Lee,
Sascha Hauer, Sean Paul, Seung-Woo Kim, Shawn Guo, Sumit Semwal,
Thomas Zimmermann, YT SHEN
This set contains fixes for some "wouldn't it be nice if" issues,
however most of the patches seen here have been on the MLs, but
were left unreviewed.
Lee Jones (42):
drm/amd/amdgpu/atombios_encoders: Remove set but unused variable
'backlight_level'
drm/armada/armada_overlay: Staticify local function
'armada_overlay_duplicate_state'
drm/drm_dp_mst_topology: Remove set but never used variable 'len'
drm/exynos/exynos7_drm_decon: Supply missing description for param
'ctx'
drm/exynos/exynos_drm_fimd: Add missing description for param 'ctx'
drm/exynos/exynos_drm_gsc: Supply missing description for 'num_limits'
drm/mediatek/mtk_dpi: Remove unused struct definition
'mtk_dpi_encoder_funcs'
drm/mediatek/mtk_disp_color: Fix formatting and provide missing member
description
drm/mediatek/mtk_disp_ovl: Fix formatting and provide missing member
description
drm/mediatek/mtk_disp_rdma: Fix formatting and supply missing struct
member description
drm/mediatek/mtk_drm_crtc: Demote seriously out-of-date struct header
drm/mediatek/mtk_drm_drv: Staticise local function invoked by
reference
drm/meson/meson_venc: Make local function
'meson_venc_hdmi_get_dmt_vmode' static
drm/meson/meson_vclk: Make two local functions static
drm/msm/adreno/a6xx_gpu: Staticise local function 'a6xx_idle'
drm/msm/disp/mdp5/mdp5_crtc: Make local function
'mdp5_crtc_setup_pipeline()' static
drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers
drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en,dis}able()'
static
drm/msm/disp/dpu1/dpu_core_perf: Remove set but unused variable
'dpu_cstate'
drm/msm/disp/dpu1/dpu_encoder: Remove a bunch of unused variables
drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param
description
drm/pl111/pl111_display: Make local function static
drm/pl111/pl111_debugfs: Make local function 'pl111_debugfs_regs()'
static
drm/rockchip/dw-mipi-dsi-rockchip: Demote non-conformant kernel-doc
headers
drm/rockchip/rockchip_rgb: Consume our own header
drm/rockchip/rockchip_lvds: Fix struct document formatting
drm/selftests/test-drm_mm: Mark 'hole_end' as always_unused
drm/selftests/test-drm_framebuffer: Remove set but unused variable
'fb'
drm/selftests/test-drm_dp_mst_helper: Place 'struct
drm_dp_sideband_msg_req_body' onto the heap
drm/selftests/test-drm_dp_mst_helper: Move
'sideband_msg_req_encode_decode' onto the heap
drm/ttm/ttm_bo: Fix one function header - demote lots of kernel-doc
abuses
drm/ttm/ttm_tt: Demote kernel-doc header format abuses
drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'
drm/v3d/v3d_gem: Provide descriptions for 'v3d_lookup_bos's params
drm/v3d/v3d_sched: Demote non-conformant kernel-doc header
drm/vc4/vc4_hdmi_regs: Mark some data sets as __maybe_unused
drm/vc4/vc4_hdmi: Remove set but unused variable 'ret'
drm/vc4/vc4_v3d: Demote non-conformant kernel-doc headers
drm/vc4/vc4_debugfs: Demote non-conformant kernel-doc headers
gpu/ipu-v3/ipu-di: Strip out 2 unused 'di_sync_config' entries
include/drm/drm_atomic: Make use of 'new_crtc_state'
.../gpu/drm/amd/amdgpu/atombios_encoders.c | 3 --
drivers/gpu/drm/armada/armada_overlay.c | 2 +-
drivers/gpu/drm/drm_dp_mst_topology.c | 4 +-
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 +
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 +
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 +
drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 ++-
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 ++-
drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 5 ++-
drivers/gpu/drm/mediatek/mtk_dpi.c | 9 -----
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +-
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +-
drivers/gpu/drm/meson/meson_vclk.c | 8 ++--
drivers/gpu/drm/meson/meson_venc.c | 4 +-
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 3 --
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +-----
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 6 +--
drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c | 6 +--
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 4 +-
drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +++--
drivers/gpu/drm/pl111/pl111_debugfs.c | 2 +-
drivers/gpu/drm/pl111/pl111_display.c | 2 +-
.../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 4 +-
drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 +
.../drm/selftests/test-drm_dp_mst_helper.c | 40 +++++++++++++------
.../gpu/drm/selftests/test-drm_framebuffer.c | 3 +-
drivers/gpu/drm/selftests/test-drm_mm.c | 2 +-
drivers/gpu/drm/ttm/ttm_bo.c | 23 ++++++-----
drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +-
drivers/gpu/drm/ttm/ttm_tt.c | 4 +-
drivers/gpu/drm/v3d/v3d_drv.c | 36 -----------------
drivers/gpu/drm/v3d/v3d_gem.c | 2 +
drivers/gpu/drm/v3d/v3d_sched.c | 2 +-
drivers/gpu/drm/vc4/vc4_debugfs.c | 4 +-
drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +-
drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 6 +--
drivers/gpu/drm/vc4/vc4_v3d.c | 4 +-
drivers/gpu/ipu-v3/ipu-di.c | 4 --
include/drm/drm_atomic.h | 3 +-
41 files changed, 105 insertions(+), 142 deletions(-)
Cc: Ajay Kumar <ajaykumar.rs@samsung.com>
Cc: Akshu Agarwal <akshua@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Chris Zhong <zyw@rock-chips.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: David Francis <David.Francis@amd.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Eric Anholt <eric@anholt.net>
Cc: Eunchul Kim <chulspro.kim@samsung.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: freedreno@lists.freedesktop.org
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Jie Qiu <jie.qiu@mediatek.com>
Cc: Jinyoung Jeon <jy0.jeon@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Kalyan Thota <kalyan_t@codeaurora.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-media@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Nickey Yang <nickey.yang@rock-chips.com>
Cc: Nirmoy Das <nirmoy.aiemd@gmail.com>
Cc: nouveau@lists.freedesktop.org
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: Sangmin Lee <lsmin.lee@samsung.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Sean Paul <sean@poorly.run>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: YT SHEN <yt.shen@mediatek.com>
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level'
2020-11-16 17:33 [RESEND 00/42] Rid W=1 warnings from GPU (non-Radeon) Lee Jones
@ 2020-11-16 17:33 ` Lee Jones
2020-11-16 17:33 ` [PATCH 02/42] drm/armada/armada_overlay: Staticify local function 'armada_overlay_duplicate_state' Lee Jones
2020-11-16 17:33 ` [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len' Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2020-11-16 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alex Deucher, Christian König, David Airlie,
Daniel Vetter, Luben Tuikov, amd-gfx, dri-devel
Also removing the call to amdgpu_atombios_encoder_get_backlight_level_from_reg()
since, according to Alex Deucher, "We call it again below indirectly".
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: In function ‘amdgpu_atombios_encoder_init_backlight’:
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c:174:5: warning: variable ‘backlight_level’ set but not used [-Wunused-but-set-variable]
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
index fa817ebff9804..6134ed9640279 100644
--- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
+++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
@@ -171,7 +171,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode
struct backlight_properties props;
struct amdgpu_backlight_privdata *pdata;
struct amdgpu_encoder_atom_dig *dig;
- u8 backlight_level;
char bl_name[16];
/* Mac laptops with multiple GPUs use the gmux driver for backlight
@@ -207,8 +206,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode
pdata->encoder = amdgpu_encoder;
- backlight_level = amdgpu_atombios_encoder_get_backlight_level_from_reg(adev);
-
dig = amdgpu_encoder->enc_priv;
dig->bl_dev = bd;
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 02/42] drm/armada/armada_overlay: Staticify local function 'armada_overlay_duplicate_state'
2020-11-16 17:33 [RESEND 00/42] Rid W=1 warnings from GPU (non-Radeon) Lee Jones
2020-11-16 17:33 ` [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones
@ 2020-11-16 17:33 ` Lee Jones
2020-11-16 17:33 ` [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len' Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2020-11-16 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Russell King, David Airlie, Daniel Vetter, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/armada/armada_overlay.c:329:1: warning: no previous prototype for ‘armada_overlay_duplicate_state’ [-Wmissing-prototypes]
Cc: Russell King <linux@armlinux.org.uk>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/armada/armada_overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_overlay.c b/drivers/gpu/drm/armada/armada_overlay.c
index 30e01101f59ed..6346b890279a0 100644
--- a/drivers/gpu/drm/armada/armada_overlay.c
+++ b/drivers/gpu/drm/armada/armada_overlay.c
@@ -325,7 +325,7 @@ static void armada_overlay_reset(struct drm_plane *plane)
}
}
-struct drm_plane_state *
+static struct drm_plane_state *
armada_overlay_duplicate_state(struct drm_plane *plane)
{
struct armada_overlay_state *state;
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len'
2020-11-16 17:33 [RESEND 00/42] Rid W=1 warnings from GPU (non-Radeon) Lee Jones
2020-11-16 17:33 ` [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones
2020-11-16 17:33 ` [PATCH 02/42] drm/armada/armada_overlay: Staticify local function 'armada_overlay_duplicate_state' Lee Jones
@ 2020-11-16 17:33 ` Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2020-11-16 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_dp_send_query_stream_enc_status’:
drivers/gpu/drm/drm_dp_mst_topology.c:3263:6: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/drm_dp_mst_topology.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index e875425336406..0401b2f475002 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -3260,7 +3260,7 @@ int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,
{
struct drm_dp_sideband_msg_tx *txmsg;
u8 nonce[7];
- int len, ret;
+ int ret;
txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL);
if (!txmsg)
@@ -3281,7 +3281,7 @@ int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,
*/
txmsg->dst = mgr->mst_primary;
- len = build_query_stream_enc_status(txmsg, port->vcpi.vcpi, nonce);
+ build_query_stream_enc_status(txmsg, port->vcpi.vcpi, nonce);
drm_dp_queue_down_tx(mgr, txmsg);
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 00/42] Rid W=1 warnings from GPU (non-Radeon)
@ 2020-11-16 17:40 Lee Jones
2020-11-16 17:40 ` [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2020-11-16 17:40 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Ajay Kumar, Akshu Agarwal, Alex Deucher, amd-gfx,
Ben Skeggs, Christian Koenig, Chris Zhong, Chun-Kuang Hu,
Daniel Vetter, David Airlie, David Francis, dri-devel,
Eric Anholt, Eunchul Kim, Fabio Estevam, freedreno,
Heiko Stübner, Huang Rui, Inki Dae, Jerome Brunet, Jie Qiu,
Jinyoung Jeon, Joonyoung Shim, Kalyan Thota, Kevin Hilman,
Krzysztof Kozlowski, Kyungmin Park, linaro-mm-sig, linux-amlogic,
linux-arm-kernel, linux-arm-msm, linux-mediatek, linux-media,
linux-rockchip, linux-samsung-soc, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Mark Yao, Martin Blumenstingl,
Matthias Brugger, Maxime Ripard, Neil Armstrong, Nickey Yang,
Nirmoy Das, nouveau, NXP Linux Team, Pengutronix Kernel Team,
Philipp Zabel, Rob Clark, Russell King, Sandy Huang, Sangmin Lee,
Sascha Hauer, Sean Paul, Seung-Woo Kim, Shawn Guo, Sumit Semwal,
Thomas Zimmermann, YT SHEN
[sending again, as `git send-email` crashed!]
This set contains fixes for some "wouldn't it be nice if" issues,
however most of the patches seen here have been on the MLs, but
were left unreviewed.
Lee Jones (42):
drm/amd/amdgpu/atombios_encoders: Remove set but unused variable
'backlight_level'
drm/armada/armada_overlay: Staticify local function
'armada_overlay_duplicate_state'
drm/drm_dp_mst_topology: Remove set but never used variable 'len'
drm/exynos/exynos7_drm_decon: Supply missing description for param
'ctx'
drm/exynos/exynos_drm_fimd: Add missing description for param 'ctx'
drm/exynos/exynos_drm_gsc: Supply missing description for 'num_limits'
drm/mediatek/mtk_dpi: Remove unused struct definition
'mtk_dpi_encoder_funcs'
drm/mediatek/mtk_disp_color: Fix formatting and provide missing member
description
drm/mediatek/mtk_disp_ovl: Fix formatting and provide missing member
description
drm/mediatek/mtk_disp_rdma: Fix formatting and supply missing struct
member description
drm/mediatek/mtk_drm_crtc: Demote seriously out-of-date struct header
drm/mediatek/mtk_drm_drv: Staticise local function invoked by
reference
drm/meson/meson_venc: Make local function
'meson_venc_hdmi_get_dmt_vmode' static
drm/meson/meson_vclk: Make two local functions static
drm/msm/adreno/a6xx_gpu: Staticise local function 'a6xx_idle'
drm/msm/disp/mdp5/mdp5_crtc: Make local function
'mdp5_crtc_setup_pipeline()' static
drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers
drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en,dis}able()'
static
drm/msm/disp/dpu1/dpu_core_perf: Remove set but unused variable
'dpu_cstate'
drm/msm/disp/dpu1/dpu_encoder: Remove a bunch of unused variables
drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param
description
drm/pl111/pl111_display: Make local function static
drm/pl111/pl111_debugfs: Make local function 'pl111_debugfs_regs()'
static
drm/rockchip/dw-mipi-dsi-rockchip: Demote non-conformant kernel-doc
headers
drm/rockchip/rockchip_rgb: Consume our own header
drm/rockchip/rockchip_lvds: Fix struct document formatting
drm/selftests/test-drm_mm: Mark 'hole_end' as always_unused
drm/selftests/test-drm_framebuffer: Remove set but unused variable
'fb'
drm/selftests/test-drm_dp_mst_helper: Place 'struct
drm_dp_sideband_msg_req_body' onto the heap
drm/selftests/test-drm_dp_mst_helper: Move
'sideband_msg_req_encode_decode' onto the heap
drm/ttm/ttm_bo: Fix one function header - demote lots of kernel-doc
abuses
drm/ttm/ttm_tt: Demote kernel-doc header format abuses
drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'
drm/v3d/v3d_gem: Provide descriptions for 'v3d_lookup_bos's params
drm/v3d/v3d_sched: Demote non-conformant kernel-doc header
drm/vc4/vc4_hdmi_regs: Mark some data sets as __maybe_unused
drm/vc4/vc4_hdmi: Remove set but unused variable 'ret'
drm/vc4/vc4_v3d: Demote non-conformant kernel-doc headers
drm/vc4/vc4_debugfs: Demote non-conformant kernel-doc headers
gpu/ipu-v3/ipu-di: Strip out 2 unused 'di_sync_config' entries
include/drm/drm_atomic: Make use of 'new_crtc_state'
.../gpu/drm/amd/amdgpu/atombios_encoders.c | 3 --
drivers/gpu/drm/armada/armada_overlay.c | 2 +-
drivers/gpu/drm/drm_dp_mst_topology.c | 4 +-
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 +
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 +
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 +
drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 ++-
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 ++-
drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 5 ++-
drivers/gpu/drm/mediatek/mtk_dpi.c | 9 -----
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +-
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +-
drivers/gpu/drm/meson/meson_vclk.c | 8 ++--
drivers/gpu/drm/meson/meson_venc.c | 4 +-
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 3 --
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +-----
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 6 +--
drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c | 6 +--
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 4 +-
drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +++--
drivers/gpu/drm/pl111/pl111_debugfs.c | 2 +-
drivers/gpu/drm/pl111/pl111_display.c | 2 +-
.../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 4 +-
drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 +
.../drm/selftests/test-drm_dp_mst_helper.c | 40 +++++++++++++------
.../gpu/drm/selftests/test-drm_framebuffer.c | 3 +-
drivers/gpu/drm/selftests/test-drm_mm.c | 2 +-
drivers/gpu/drm/ttm/ttm_bo.c | 23 ++++++-----
drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +-
drivers/gpu/drm/ttm/ttm_tt.c | 4 +-
drivers/gpu/drm/v3d/v3d_drv.c | 36 -----------------
drivers/gpu/drm/v3d/v3d_gem.c | 2 +
drivers/gpu/drm/v3d/v3d_sched.c | 2 +-
drivers/gpu/drm/vc4/vc4_debugfs.c | 4 +-
drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +-
drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 6 +--
drivers/gpu/drm/vc4/vc4_v3d.c | 4 +-
drivers/gpu/ipu-v3/ipu-di.c | 4 --
include/drm/drm_atomic.h | 3 +-
41 files changed, 105 insertions(+), 142 deletions(-)
Cc: Ajay Kumar <ajaykumar.rs@samsung.com>
Cc: Akshu Agarwal <akshua@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Chris Zhong <zyw@rock-chips.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: David Francis <David.Francis@amd.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Eric Anholt <eric@anholt.net>
Cc: Eunchul Kim <chulspro.kim@samsung.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: freedreno@lists.freedesktop.org
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Jie Qiu <jie.qiu@mediatek.com>
Cc: Jinyoung Jeon <jy0.jeon@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Kalyan Thota <kalyan_t@codeaurora.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-media@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Nickey Yang <nickey.yang@rock-chips.com>
Cc: Nirmoy Das <nirmoy.aiemd@gmail.com>
Cc: nouveau@lists.freedesktop.org
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: Sangmin Lee <lsmin.lee@samsung.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Sean Paul <sean@poorly.run>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: YT SHEN <yt.shen@mediatek.com>
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level'
2020-11-16 17:40 [PATCH v2 00/42] Rid W=1 warnings from GPU (non-Radeon) Lee Jones
@ 2020-11-16 17:40 ` Lee Jones
2020-11-16 20:51 ` Alex Deucher
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2020-11-16 17:40 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alex Deucher, Christian König, David Airlie,
Daniel Vetter, Luben Tuikov, amd-gfx, dri-devel
Also removing the call to amdgpu_atombios_encoder_get_backlight_level_from_reg()
since, according to Alex Deucher, "We call it again below indirectly".
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: In function ‘amdgpu_atombios_encoder_init_backlight’:
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c:174:5: warning: variable ‘backlight_level’ set but not used [-Wunused-but-set-variable]
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
index fa817ebff9804..6134ed9640279 100644
--- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
+++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
@@ -171,7 +171,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode
struct backlight_properties props;
struct amdgpu_backlight_privdata *pdata;
struct amdgpu_encoder_atom_dig *dig;
- u8 backlight_level;
char bl_name[16];
/* Mac laptops with multiple GPUs use the gmux driver for backlight
@@ -207,8 +206,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode
pdata->encoder = amdgpu_encoder;
- backlight_level = amdgpu_atombios_encoder_get_backlight_level_from_reg(adev);
-
dig = amdgpu_encoder->enc_priv;
dig->bl_dev = bd;
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level'
2020-11-16 17:40 ` [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones
@ 2020-11-16 20:51 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2020-11-16 20:51 UTC (permalink / raw)
To: Lee Jones
Cc: David Airlie, LKML, amd-gfx list, Luben Tuikov,
Maling list - DRI developers, Alex Deucher, Christian König
On Mon, Nov 16, 2020 at 12:41 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Also removing the call to amdgpu_atombios_encoder_get_backlight_level_from_reg()
> since, according to Alex Deucher, "We call it again below indirectly".
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: In function ‘amdgpu_atombios_encoder_init_backlight’:
> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c:174:5: warning: variable ‘backlight_level’ set but not used [-Wunused-but-set-variable]
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> index fa817ebff9804..6134ed9640279 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> @@ -171,7 +171,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode
> struct backlight_properties props;
> struct amdgpu_backlight_privdata *pdata;
> struct amdgpu_encoder_atom_dig *dig;
> - u8 backlight_level;
> char bl_name[16];
>
> /* Mac laptops with multiple GPUs use the gmux driver for backlight
> @@ -207,8 +206,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode
>
> pdata->encoder = amdgpu_encoder;
>
> - backlight_level = amdgpu_atombios_encoder_get_backlight_level_from_reg(adev);
> -
> dig = amdgpu_encoder->enc_priv;
> dig->bl_dev = bd;
>
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-16 20:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 17:33 [RESEND 00/42] Rid W=1 warnings from GPU (non-Radeon) Lee Jones
2020-11-16 17:33 ` [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones
2020-11-16 17:33 ` [PATCH 02/42] drm/armada/armada_overlay: Staticify local function 'armada_overlay_duplicate_state' Lee Jones
2020-11-16 17:33 ` [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len' Lee Jones
2020-11-16 17:40 [PATCH v2 00/42] Rid W=1 warnings from GPU (non-Radeon) Lee Jones
2020-11-16 17:40 ` [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones
2020-11-16 20:51 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®