* [PATCH] speakup: fix uninitialized flush_lock
@ 2020-11-17 1:22 Yang Yingliang
2020-11-17 6:59 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2020-11-17 1:22 UTC (permalink / raw)
To: speakup, linux-kernel; +Cc: w.d.hubbs, samuel.thibault, gregkh, yangyingliang
The flush_lock is uninitialized, use DEFINE_SPINLOCK
to define and initialize flush_lock.
Fixes: c6e3fd22cd53 ("Staging: add speakup to the staging directory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/accessibility/speakup/speakup_dectlk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/speakup/speakup_dectlk.c b/drivers/accessibility/speakup/speakup_dectlk.c
index 780214b5ca16..ab6d61e80b1c 100644
--- a/drivers/accessibility/speakup/speakup_dectlk.c
+++ b/drivers/accessibility/speakup/speakup_dectlk.c
@@ -37,7 +37,7 @@ static unsigned char get_index(struct spk_synth *synth);
static int in_escape;
static int is_flushing;
-static spinlock_t flush_lock;
+static DEFINE_SPINLOCK(flush_lock);
static DECLARE_WAIT_QUEUE_HEAD(flush);
static struct var_t vars[] = {
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] speakup: fix uninitialized flush_lock
2020-11-17 1:22 [PATCH] speakup: fix uninitialized flush_lock Yang Yingliang
@ 2020-11-17 6:59 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2020-11-17 6:59 UTC (permalink / raw)
To: Yang Yingliang; +Cc: speakup, linux-kernel, w.d.hubbs, gregkh
Yang Yingliang, le mar. 17 nov. 2020 09:22:29 +0800, a ecrit:
> The flush_lock is uninitialized, use DEFINE_SPINLOCK
> to define and initialize flush_lock.
>
> Fixes: c6e3fd22cd53 ("Staging: add speakup to the staging directory")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/speakup_dectlk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/speakup_dectlk.c b/drivers/accessibility/speakup/speakup_dectlk.c
> index 780214b5ca16..ab6d61e80b1c 100644
> --- a/drivers/accessibility/speakup/speakup_dectlk.c
> +++ b/drivers/accessibility/speakup/speakup_dectlk.c
> @@ -37,7 +37,7 @@ static unsigned char get_index(struct spk_synth *synth);
> static int in_escape;
> static int is_flushing;
>
> -static spinlock_t flush_lock;
> +static DEFINE_SPINLOCK(flush_lock);
> static DECLARE_WAIT_QUEUE_HEAD(flush);
>
> static struct var_t vars[] = {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-17 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 1:22 [PATCH] speakup: fix uninitialized flush_lock Yang Yingliang
2020-11-17 6:59 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®