* [PATCH] cxgb4: Fix build failure when CONFIG_TLS=m [not found] <20201120073502.4beeb482@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> @ 2020-11-20 19:25 ` Tom Seewald 2020-11-21 21:12 ` Jakub Kicinski 0 siblings, 1 reply; 2+ messages in thread From: Tom Seewald @ 2020-11-20 19:25 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, davem, kuba, ayush.sawal, rajur, Tom Seewald After commit 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough") whenever CONFIG_TLS=m and CONFIG_CHELSIO_T4=y, the following build failure occurs: ld: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o: in function `cxgb_select_queue': cxgb4_main.c:(.text+0x2dac): undefined reference to `tls_validate_xmit_skb' Fix this by ensuring that if TLS is set to be a module, CHELSIO_T4 will also be compiled as a module. As otherwise the cxgb4 driver will not be able to access TLS' symbols. Fixes: 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough") Signed-off-by: Tom Seewald <tseewald@gmail.com> --- drivers/net/ethernet/chelsio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/Kconfig b/drivers/net/ethernet/chelsio/Kconfig index 87cc0ef68b31..8ba0e08e5e64 100644 --- a/drivers/net/ethernet/chelsio/Kconfig +++ b/drivers/net/ethernet/chelsio/Kconfig @@ -68,7 +68,7 @@ config CHELSIO_T3 config CHELSIO_T4 tristate "Chelsio Communications T4/T5/T6 Ethernet support" - depends on PCI && (IPV6 || IPV6=n) + depends on PCI && (IPV6 || IPV6=n) && (TLS || TLS=n) select FW_LOADER select MDIO select ZLIB_DEFLATE -- 2.20.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cxgb4: Fix build failure when CONFIG_TLS=m 2020-11-20 19:25 ` [PATCH] cxgb4: Fix build failure when CONFIG_TLS=m Tom Seewald @ 2020-11-21 21:12 ` Jakub Kicinski 0 siblings, 0 replies; 2+ messages in thread From: Jakub Kicinski @ 2020-11-21 21:12 UTC (permalink / raw) To: Tom Seewald; +Cc: netdev, linux-kernel, davem, ayush.sawal, rajur On Fri, 20 Nov 2020 13:25:28 -0600 Tom Seewald wrote: > After commit 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough") > whenever CONFIG_TLS=m and CONFIG_CHELSIO_T4=y, the following build > failure occurs: > > ld: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o: in function > `cxgb_select_queue': > cxgb4_main.c:(.text+0x2dac): undefined reference to `tls_validate_xmit_skb' > > Fix this by ensuring that if TLS is set to be a module, CHELSIO_T4 will > also be compiled as a module. As otherwise the cxgb4 driver will not be > able to access TLS' symbols. > > Fixes: 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough") > Signed-off-by: Tom Seewald <tseewald@gmail.com> Applied, thanks! ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-21 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201120073502.4beeb482@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
2020-11-20 19:25 ` [PATCH] cxgb4: Fix build failure when CONFIG_TLS=m Tom Seewald
2020-11-21 21:12 ` Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®