From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, zhouyanjie@wanyeetech.com,
paul@crapouillou.net, paul@boddie.org.uk, hns@goldelico.com,
kernel test robot <lkp@intel.com>
Subject: [PATCH] clocksource/drivers/ingenic: Fix section mismatch
Date: Wed, 25 Nov 2020 11:23:45 +0100 [thread overview]
Message-ID: <20201125102346.1816310-1-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <202011251435.7F0RQBXw-lkp@intel.com>
The function ingenic_tcu_get_clock() is annotated for the __init
section but it is actually called from the online cpu callback.
That will lead to a crash if a CPU is hotplugged after boot time.
Remove the __init annotatation for the ingenic_tcu_get_clock()
function.
Fixes: f19d838d08fc (clocksource/drivers/ingenic: Add high resolution timer support for SMP/SMT)
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/ingenic-timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/ingenic-timer.c b/drivers/clocksource/ingenic-timer.c
index 58fd9189fab7..905fd6b163a8 100644
--- a/drivers/clocksource/ingenic-timer.c
+++ b/drivers/clocksource/ingenic-timer.c
@@ -127,7 +127,7 @@ static irqreturn_t ingenic_tcu_cevt_cb(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static struct clk * __init ingenic_tcu_get_clock(struct device_node *np, int id)
+static struct clk *ingenic_tcu_get_clock(struct device_node *np, int id)
{
struct of_phandle_args args;
--
2.25.1
next prev parent reply other threads:[~2020-11-25 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 6:21 WARNING: modpost: vmlinux.o(.text.unlikely+0x1d0d8): Section mismatch in reference from the function ingenic_tcu_setup_cevt() to the function .init.text:ingenic_tcu_get_clock() kernel test robot
2020-11-25 10:23 ` Daniel Lezcano [this message]
2020-11-25 10:45 ` [PATCH] clocksource/drivers/ingenic: Fix section mismatch Paul Cercueil
2020-11-25 17:34 ` Zhou Yanjie
2020-12-03 23:47 ` [tip: timers/core] " tip-bot2 for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125102346.1816310-1-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=tglx@linutronix.de \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®