From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, paul@crapouillou.net,
paul@boddie.org.uk, hns@goldelico.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] clocksource/drivers/ingenic: Fix section mismatch
Date: Thu, 26 Nov 2020 01:34:50 +0800 [thread overview]
Message-ID: <61742e23-5b09-5c6c-fdaf-1500f089987e@wanyeetech.com> (raw)
In-Reply-To: <20201125102346.1816310-1-daniel.lezcano@linaro.org>
Hi Daniel,
在 2020/11/25 下午6:23, Daniel Lezcano 写道:
> The function ingenic_tcu_get_clock() is annotated for the __init
> section but it is actually called from the online cpu callback.
>
> That will lead to a crash if a CPU is hotplugged after boot time.
>
> Remove the __init annotatation for the ingenic_tcu_get_clock()
> function.
>
> Fixes: f19d838d08fc (clocksource/drivers/ingenic: Add high resolution timer support for SMP/SMT)
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/clocksource/ingenic-timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Works fine on JZ4780, X1000, and X1830.
Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Thanks and best regards!
> diff --git a/drivers/clocksource/ingenic-timer.c b/drivers/clocksource/ingenic-timer.c
> index 58fd9189fab7..905fd6b163a8 100644
> --- a/drivers/clocksource/ingenic-timer.c
> +++ b/drivers/clocksource/ingenic-timer.c
> @@ -127,7 +127,7 @@ static irqreturn_t ingenic_tcu_cevt_cb(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -static struct clk * __init ingenic_tcu_get_clock(struct device_node *np, int id)
> +static struct clk *ingenic_tcu_get_clock(struct device_node *np, int id)
> {
> struct of_phandle_args args;
>
next prev parent reply other threads:[~2020-11-25 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 6:21 WARNING: modpost: vmlinux.o(.text.unlikely+0x1d0d8): Section mismatch in reference from the function ingenic_tcu_setup_cevt() to the function .init.text:ingenic_tcu_get_clock() kernel test robot
2020-11-25 10:23 ` [PATCH] clocksource/drivers/ingenic: Fix section mismatch Daniel Lezcano
2020-11-25 10:45 ` Paul Cercueil
2020-11-25 17:34 ` Zhou Yanjie [this message]
2020-12-03 23:47 ` [tip: timers/core] " tip-bot2 for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61742e23-5b09-5c6c-fdaf-1500f089987e@wanyeetech.com \
--to=zhouyanjie@wanyeetech.com \
--cc=daniel.lezcano@linaro.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®