From: Mike Rapoport <rppt@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
Baoquan He <bhe@redhat.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Eric Biggers <ebiggers@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ira Weiny <ira.weiny@intel.com>, Jens Axboe <axboe@kernel.dk>,
Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
Manish Narani <manish.narani@xilinx.com>,
Oleg Nesterov <oleg@redhat.com>,
Pekka Enberg <penberg@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
Rob Herring <robh@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Stafford Horne <shorne@gmail.com>,
Stefan Asserhall <stefan.asserhall@xilinx.com>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] microblaze: Remove noMMU code
Date: Wed, 25 Nov 2020 14:54:40 +0200 [thread overview]
Message-ID: <20201125125440.GP8537@kernel.org> (raw)
In-Reply-To: <7217421a-c4de-0bd1-3231-17563e51e3c9@xilinx.com>
Hi Michal,
On Wed, Nov 25, 2020 at 01:14:49PM +0100, Michal Simek wrote:
> Hi Mike,
>
> On 25. 11. 20 13:07, Mike Rapoport wrote:
> > On Wed, Nov 25, 2020 at 12:30:32PM +0100, Michal Simek wrote:
> >> This configuration is obsolete and likely none is really using it. That's
> >> why remove it to simplify code.
> >>
> >> Cc: Arnd Bergmann <arnd@arndb.de>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >
> > Looks ok to me except several leftovers:
> >
> > $ git grep CONFIG_MMU arch/microblaze/
> > arch/microblaze/kernel/hw_exception_handler.S: * STACK FRAME STRUCTURE (for CONFIG_MMU=n)
> >
> > $ git grep -E 'MICROBLAZE_(64|16)K_PAGES'
> > arch/microblaze/include/asm/page.h:#if defined(CONFIG_MICROBLAZE_64K_PAGES)
> > arch/microblaze/include/asm/page.h:#elif defined(CONFIG_MICROBLAZE_16K_PAGES)
> > arch/microblaze/kernel/hw_exception_handler.S:#ifdef CONFIG_MICROBLAZE_64K_PAGES
> > arch/microblaze/kernel/hw_exception_handler.S:#elif CONFIG_MICROBLAZE_16K_PAGES
> > drivers/net/Kconfig: IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \
> >
> >
>
> I left it there intentionally. First one because there is description in
> that comment which references noMMU. If this should be removed the whole
> comment should be tuned to make sense. It is better to do it in separate
> patch.
Makes sense, I just grepped without actually opening the files :)
> And second part. I know I removed that Kconfig macros for it but maybe
> good to talk about what needs to change to support different page size
> for systems with MMU.
I'd add a sentence about it to the changelog.
> Thanks,
> Michal
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-11-25 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 11:30 Michal Simek
2020-11-25 12:07 ` Mike Rapoport
2020-11-25 12:14 ` Michal Simek
2020-11-25 12:54 ` Mike Rapoport [this message]
2020-11-25 12:57 ` Arnd Bergmann
2020-11-25 13:01 ` Michal Simek
2020-11-25 13:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125125440.GP8537@kernel.org \
--to=rppt@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bhe@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=christian.brauner@ubuntu.com \
--cc=ebiggers@google.com \
--cc=geert@linux-m68k.org \
--cc=git@xilinx.com \
--cc=gustavoars@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=ira.weiny@intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nivedita@alum.mit.edu \
--cc=oleg@redhat.com \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=shorne@gmail.com \
--cc=stefan.asserhall@xilinx.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®