mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Arnd Bergmann <arnd@kernel.org>, Michal Simek <michal.simek@xilinx.com>
Cc: Mike Rapoport <rppt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Michal Simek <monstr@monstr.eu>, git <git@xilinx.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Arvind Sankar <nivedita@alum.mit.edu>,
	Baoquan He <bhe@redhat.com>,
	"Christian Brauner" <christian.brauner@ubuntu.com>,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Eric Biggers <ebiggers@google.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Ira Weiny <ira.weiny@intel.com>, Jens Axboe <axboe@kernel.dk>,
	Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
	Manish Narani <manish.narani@xilinx.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Pekka Enberg <penberg@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	Rob Herring <robh@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Stafford Horne <shorne@gmail.com>,
	Stefan Asserhall <stefan.asserhall@xilinx.com>,
	"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
	Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] microblaze: Remove noMMU code
Date: Wed, 25 Nov 2020 14:01:15 +0100	[thread overview]
Message-ID: <5947a4da-a08f-049b-9162-628e42980b33@xilinx.com> (raw)
In-Reply-To: <CAK8P3a3QkWTCDg+v9qtW0aG7ndhmSukuZG-znS_NzRHyoZLQhw@mail.gmail.com>



On 25. 11. 20 13:57, Arnd Bergmann wrote:
> On Wed, Nov 25, 2020 at 1:14 PM Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> And second part. I know I removed that Kconfig macros for it but maybe
>> good to talk about what needs to change to support different page size
>> for systems with MMU.
> 
> I would recommend just leaving it hardwired to 4K. The benefits of larger
> pages are rather questionable, especially on systems without tons of
> RAM, and it's an endless source of problems.
> 
> The commit that added the option, ba9c4f88d747 ("microblaze: Allow
> PAGE_SIZE configuration"), was rather nebulous with "can improve
> performance on some workloads".
> 
> On PowerPC, the benefits of larger pages are mainly for the hashed
> page table code, which I don't think exists anywhere else.

Is there any standard benchmark to see if there is really any benefit?
Exchanging tbl is quite expensive operation that's why there could be
good improvement.

But not a problem to remove it for now and get it back when this is
properly tested.

Thanks,
Michal

  reply	other threads:[~2020-11-25 13:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 11:30 Michal Simek
2020-11-25 12:07 ` Mike Rapoport
2020-11-25 12:14   ` Michal Simek
2020-11-25 12:54     ` Mike Rapoport
2020-11-25 12:57     ` Arnd Bergmann
2020-11-25 13:01       ` Michal Simek [this message]
2020-11-25 13:57         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5947a4da-a08f-049b-9162-628e42980b33@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bhe@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=ebiggers@google.com \
    --cc=geert@linux-m68k.org \
    --cc=git@xilinx.com \
    --cc=gustavoars@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=ira.weiny@intel.com \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manish.narani@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=nivedita@alum.mit.edu \
    --cc=oleg@redhat.com \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=shorne@gmail.com \
    --cc=stefan.asserhall@xilinx.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®