* [PATCH] gfs2: remove trailing semicolon in macro definition
@ 2020-11-27 19:12 trix
2020-11-27 20:30 ` Andreas Gruenbacher
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-11-27 19:12 UTC (permalink / raw)
To: rpeterso, agruenba; +Cc: cluster-devel, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/gfs2/util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/util.h b/fs/gfs2/util.h
index d7562981b3a0..493020393ceb 100644
--- a/fs/gfs2/util.h
+++ b/fs/gfs2/util.h
@@ -162,7 +162,7 @@ void gfs2_io_error_bh_i(struct gfs2_sbd *sdp, struct buffer_head *bh,
gfs2_io_error_bh_i((sdp), (bh), __func__, __FILE__, __LINE__, true);
#define gfs2_io_error_bh(sdp, bh) \
-gfs2_io_error_bh_i((sdp), (bh), __func__, __FILE__, __LINE__, false);
+gfs2_io_error_bh_i((sdp), (bh), __func__, __FILE__, __LINE__, false)
extern struct kmem_cache *gfs2_glock_cachep;
--
2.18.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gfs2: remove trailing semicolon in macro definition
2020-11-27 19:12 [PATCH] gfs2: remove trailing semicolon in macro definition trix
@ 2020-11-27 20:30 ` Andreas Gruenbacher
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Gruenbacher @ 2020-11-27 20:30 UTC (permalink / raw)
To: trix; +Cc: Bob Peterson, cluster-devel, LKML
On Fri, Nov 27, 2020 at 8:12 PM <trix@redhat.com> wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> fs/gfs2/util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/util.h b/fs/gfs2/util.h
> index d7562981b3a0..493020393ceb 100644
> --- a/fs/gfs2/util.h
> +++ b/fs/gfs2/util.h
> @@ -162,7 +162,7 @@ void gfs2_io_error_bh_i(struct gfs2_sbd *sdp, struct buffer_head *bh,
> gfs2_io_error_bh_i((sdp), (bh), __func__, __FILE__, __LINE__, true);
>
> #define gfs2_io_error_bh(sdp, bh) \
> -gfs2_io_error_bh_i((sdp), (bh), __func__, __FILE__, __LINE__, false);
> +gfs2_io_error_bh_i((sdp), (bh), __func__, __FILE__, __LINE__, false)
>
>
> extern struct kmem_cache *gfs2_glock_cachep;
> --
> 2.18.4
Yeah okay, there are two more instances of exactly the same pattern
further below in the same header file. I'm adding fixes for those as
well.
Thanks,
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-27 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 19:12 [PATCH] gfs2: remove trailing semicolon in macro definition trix
2020-11-27 20:30 ` Andreas Gruenbacher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®