[PATCH] mm: remove h from printk format specifier

[PATCH] mm: remove h from printk format specifier

[trix]

From: Tom Rix <trix@redhat.com>

See Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 arch/x86/mm/fault.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 907b54d3b990..4bc4c9a6a8ae 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -486,13 +486,13 @@ static void show_ldttss(const struct desc_ptr *gdt, const char *name, u16 index)
 	}
 
 	if (offset + sizeof(struct ldttss_desc) >= gdt->size) {
-		pr_alert("%s: 0x%hx -- out of bounds\n", name, index);
+		pr_alert("%s: 0x%x -- out of bounds\n", name, index);
 		return;
 	}
 
 	if (copy_from_kernel_nofault(&desc, (void *)(gdt->address + offset),
 			      sizeof(struct ldttss_desc))) {
-		pr_alert("%s: 0x%hx -- GDT entry is not readable\n",
+		pr_alert("%s: 0x%x -- GDT entry is not readable\n",
 			 name, index);
 		return;
 	}
@@ -501,7 +501,7 @@ static void show_ldttss(const struct desc_ptr *gdt, const char *name, u16 index)
 #ifdef CONFIG_X86_64
 	addr |= ((u64)desc.base3 << 32);
 #endif
-	pr_alert("%s: 0x%hx -- base=0x%lx limit=0x%x\n",
+	pr_alert("%s: 0x%x -- base=0x%lx limit=0x%x\n",
 		 name, index, addr, (desc.limit0 | (desc.limit1 << 16)));
 }
 
@@ -569,7 +569,7 @@ show_fault_oops(struct pt_regs *regs, unsigned long error_code, unsigned long ad
 		/* Usable even on Xen PV -- it's just slow. */
 		native_store_gdt(&gdt);
 
-		pr_alert("IDT: 0x%lx (limit=0x%hx) GDT: 0x%lx (limit=0x%hx)\n",
+		pr_alert("IDT: 0x%lx (limit=0x%x) GDT: 0x%lx (limit=0x%x)\n",
 			 idt.address, idt.size, gdt.address, gdt.size);
 
 		store_ldt(ldtr);
-- 
2.27.0

Re: [PATCH] mm: remove h from printk format specifier

[Peter Zijlstra]

On Tue, Dec 15, 2020 at 06:19:31AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.

I'm not going to be reading any RST gunk. If there's a sane reason,
replicate it here, in plain text.