* [PATCH] staging: ralink-gdma: Fixed blank line coding style issue
@ 2020-12-23 20:22 Ayoub Soussi
2020-12-24 7:49 ` Greg KH
2020-12-24 17:27 ` Joe Perches
0 siblings, 2 replies; 3+ messages in thread
From: Ayoub Soussi @ 2020-12-23 20:22 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Ayoub Soussi
Fixed coding style issue.
Signed-off-by: Ayoub Soussi <ayoubfme@gmail.com>
---
drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 655df317d0ee..a6181a167814 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -122,6 +122,7 @@ struct gdma_dma_dev {
struct gdma_data *data;
void __iomem *base;
struct tasklet_struct task;
+
volatile unsigned long chan_issued;
atomic_t cnt;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: ralink-gdma: Fixed blank line coding style issue
2020-12-23 20:22 [PATCH] staging: ralink-gdma: Fixed blank line coding style issue Ayoub Soussi
@ 2020-12-24 7:49 ` Greg KH
2020-12-24 17:27 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-12-24 7:49 UTC (permalink / raw)
To: Ayoub Soussi; +Cc: devel, linux-kernel
On Wed, Dec 23, 2020 at 09:22:30PM +0100, Ayoub Soussi wrote:
> Fixed coding style issue.
>
> Signed-off-by: Ayoub Soussi <ayoubfme@gmail.com>
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 655df317d0ee..a6181a167814 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
> struct gdma_data *data;
> void __iomem *base;
> struct tasklet_struct task;
> +
> volatile unsigned long chan_issued;
> atomic_t cnt;
With your knowledge of C, does this change look correct?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: ralink-gdma: Fixed blank line coding style issue
2020-12-23 20:22 [PATCH] staging: ralink-gdma: Fixed blank line coding style issue Ayoub Soussi
2020-12-24 7:49 ` Greg KH
@ 2020-12-24 17:27 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-12-24 17:27 UTC (permalink / raw)
To: Ayoub Soussi, gregkh; +Cc: devel, linux-kernel
On Wed, 2020-12-23 at 21:22 +0100, Ayoub Soussi wrote:
> Fixed coding style issue.
[]
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
[]
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
> struct gdma_data *data;
> void __iomem *base;
> struct tasklet_struct task;
> +
> volatile unsigned long chan_issued;
> atomic_t cnt;
This is presumably a checkpatch false positive.
checkpatch is not now nor never will be a perfect tool.
Please consider what you are doing and what the desired coding style is
before submitting patches.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-24 17:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 20:22 [PATCH] staging: ralink-gdma: Fixed blank line coding style issue Ayoub Soussi
2020-12-24 7:49 ` Greg KH
2020-12-24 17:27 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome