* [PATCH] perf build: remove -Wnested-externs
@ 2020-12-24 12:24 Tian Tao
2020-12-24 13:12 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-12-24 12:24 UTC (permalink / raw)
To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
namhyung, ast, daniel, andrii, kafai, songliubraving, yhs,
john.fastabend, kpsingh
Cc: linux-kernel
since commit c93e4aeed1be
("Makefile.extrawarn: remove -Wnested-externs warning")
has removed this check, so it's not needed here.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
tools/perf/Makefile.config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index ce8516e..b9e8634 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -16,7 +16,7 @@ $(shell printf "" > $(OUTPUT).config-detected)
detected = $(shell echo "$(1)=y" >> $(OUTPUT).config-detected)
detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
-CFLAGS := $(EXTRA_CFLAGS) $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))
+CFLAGS := $(EXTRA_CFLAGS) $(EXTRA_WARNINGS)
include $(srctree)/tools/scripts/Makefile.arch
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] perf build: remove -Wnested-externs
2020-12-24 12:24 [PATCH] perf build: remove -Wnested-externs Tian Tao
@ 2020-12-24 13:12 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-12-24 13:12 UTC (permalink / raw)
To: Tian Tao
Cc: peterz, mingo, mark.rutland, alexander.shishkin, jolsa, namhyung,
ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kernel
Em Thu, Dec 24, 2020 at 08:24:06PM +0800, Tian Tao escreveu:
> since commit c93e4aeed1be
> ("Makefile.extrawarn: remove -Wnested-externs warning")
> has removed this check, so it's not needed here.
But the above commit is for the kernel, scripts/Makefile.extrawarn isn't
included in tools/perf/
This is the one used:
[acme@five perf]$ grep nested-externs tools/scripts/Makefile.include
EXTRA_WARNINGS += -Wnested-externs
[acme@five perf]$
But since you're looking at this, you could consider adding
tools/scripts/Makefile.extrawarn out of tools/scripts/Makefile.include,
etc, to better mimic what is in the kernel sources :-)
Thanks,
- Arnaldo
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> tools/perf/Makefile.config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index ce8516e..b9e8634 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -16,7 +16,7 @@ $(shell printf "" > $(OUTPUT).config-detected)
> detected = $(shell echo "$(1)=y" >> $(OUTPUT).config-detected)
> detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
>
> -CFLAGS := $(EXTRA_CFLAGS) $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))
> +CFLAGS := $(EXTRA_CFLAGS) $(EXTRA_WARNINGS)
>
> include $(srctree)/tools/scripts/Makefile.arch
>
> --
> 2.7.4
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-24 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-24 12:24 [PATCH] perf build: remove -Wnested-externs Tian Tao
2020-12-24 13:12 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome