From: David Miller <davem@davemloft.net>
To: fthain@telegraphics.com.au
Cc: kuba@kernel.org, christophe.jaillet@wanadoo.fr,
tsbogend@alpha.franken.de, chris@zankel.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in error handling paths
Date: Tue, 05 Jan 2021 16:00:18 -0800 (PST) [thread overview]
Message-ID: <20210105.160018.901800594374682376.davem@davemloft.net> (raw)
In-Reply-To: <529006a7dcd2cd345c2261d4beae0960880f4828.1609633586.git.fthain@telegraphics.com.au>
From: Finn Thain <fthain@telegraphics.com.au>
Date: Sun, 03 Jan 2021 11:26:26 +1100
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors().
>
> This is correctly freed in the remove function, but not in the error
> handling path of the probe function. Fix this by adding the missing
> dma_free_coherent() call.
>
> While at it, rename a label in order to be slightly more informative.
>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Chris Zankel <chris@zankel.net>
> References: commit 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'")
> Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.")
> Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2021-01-06 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 0:26 Finn Thain
2021-01-06 0:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105.160018.901800594374682376.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris@zankel.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=fthain@telegraphics.com.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®