mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM
@ 2021-01-06 19:15 Florian Fainelli
  2021-01-06 19:27 ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2021-01-06 19:15 UTC (permalink / raw)
  To: netdev
  Cc: Florian Fainelli, David S. Miller, Jakub Kicinski, Randy Dunlap,
	Masahiro Yamada, open list

All of the OF code that is used has stubbed and will compile and link
just fine, keeping COMPILE_TEST is enough.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/broadcom/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index 7b79528d6eed..4bdf8fbe75a6 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -174,7 +174,6 @@ config BGMAC_BCMA
 config BGMAC_PLATFORM
 	tristate "Broadcom iProc GBit platform support"
 	depends on ARCH_BCM_IPROC || COMPILE_TEST
-	depends on OF
 	select BGMAC
 	select PHYLIB
 	select FIXED_PHY
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM
  2021-01-06 19:15 [PATCH net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM Florian Fainelli
@ 2021-01-06 19:27 ` Randy Dunlap
  2021-01-07 20:52   ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-01-06 19:27 UTC (permalink / raw)
  To: Florian Fainelli, netdev
  Cc: David S. Miller, Jakub Kicinski, Masahiro Yamada, open list

On 1/6/21 11:15 AM, Florian Fainelli wrote:
> All of the OF code that is used has stubbed and will compile and link
> just fine, keeping COMPILE_TEST is enough.

Yes, that matches my understanding.

I wish we had a list of which API families have full stub support...

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/net/ethernet/broadcom/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index 7b79528d6eed..4bdf8fbe75a6 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -174,7 +174,6 @@ config BGMAC_BCMA
>  config BGMAC_PLATFORM
>  	tristate "Broadcom iProc GBit platform support"
>  	depends on ARCH_BCM_IPROC || COMPILE_TEST
> -	depends on OF
>  	select BGMAC
>  	select PHYLIB
>  	select FIXED_PHY
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM
  2021-01-06 19:27 ` Randy Dunlap
@ 2021-01-07 20:52   ` Jakub Kicinski
  0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-07 20:52 UTC (permalink / raw)
  To: Randy Dunlap, Florian Fainelli
  Cc: netdev, David S. Miller, Masahiro Yamada, open list

On Wed, 6 Jan 2021 11:27:29 -0800 Randy Dunlap wrote:
> On 1/6/21 11:15 AM, Florian Fainelli wrote:
> > All of the OF code that is used has stubbed and will compile and link
> > just fine, keeping COMPILE_TEST is enough.  
> 
> Yes, that matches my understanding.
> 
> I wish we had a list of which API families have full stub support...
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-07 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06 19:15 [PATCH net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM Florian Fainelli
2021-01-06 19:27 ` Randy Dunlap
2021-01-07 20:52   ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®