* [PATCH] drm/i915/gem: fix non-SMP build failure
@ 2021-01-25 12:25 Arnd Bergmann
2021-01-25 12:34 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-01-25 12:25 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Matthew Auld, Chris Wilson
Cc: Arnd Bergmann, Maarten Lankhorst, intel-gfx, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The x86-specific wbinvd_on_all_cpus() function is exported
through asm/smp.h, causing a build failure in the i915 driver
when SMP is disabled:
drivers/gpu/drm/i915/i915_gem.c:1182:2: error: implicit declaration of function 'wbinvd_on_all_cpus' [-Werror,-Wimplicit-function-declaration]
Include that header file explicitly.
Fixes: 30d2bfd09383 ("drm/i915/gem: Almagamate clflushes on freeze")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/i915/i915_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 9b04dff5eb32..2a1643514577 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -36,6 +36,7 @@
#include <linux/pci.h>
#include <linux/dma-buf.h>
#include <linux/mman.h>
+#include <asm/smp.h>
#include "display/intel_display.h"
#include "display/intel_frontbuffer.h"
--
2.29.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/i915/gem: fix non-SMP build failure
2021-01-25 12:25 [PATCH] drm/i915/gem: fix non-SMP build failure Arnd Bergmann
@ 2021-01-25 12:34 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2021-01-25 12:34 UTC (permalink / raw)
To: Arnd Bergmann, Daniel Vetter, David Airlie, Jani Nikula,
Joonas Lahtinen, Matthew Auld, Rodrigo Vivi
Cc: intel-gfx, dri-devel, Arnd Bergmann, linux-kernel
Quoting Arnd Bergmann (2021-01-25 12:25:34)
> From: Arnd Bergmann <arnd@arndb.de>
>
> The x86-specific wbinvd_on_all_cpus() function is exported
> through asm/smp.h, causing a build failure in the i915 driver
> when SMP is disabled:
>
> drivers/gpu/drm/i915/i915_gem.c:1182:2: error: implicit declaration of function 'wbinvd_on_all_cpus' [-Werror,-Wimplicit-function-declaration]
I thought the code was already in i915_gem_pm.c (which included smp.h);
it is now.
-Chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-25 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 12:25 [PATCH] drm/i915/gem: fix non-SMP build failure Arnd Bergmann
2021-01-25 12:34 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®