* [PATCH] init: clean up early_param_on_off() macro
@ 2021-02-01 4:15 Masahiro Yamada
2021-02-01 9:27 ` Johan Hovold
2021-02-01 15:58 ` Miguel Ojeda
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2021-02-01 4:15 UTC (permalink / raw)
To: linux-kernel, Andrew Morton
Cc: Masahiro Yamada, Joe Perches, Johan Hovold, Miguel Ojeda,
Nick Desaulniers
Use early_param() to define early_param_on_off().
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
include/linux/init.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/init.h b/include/linux/init.h
index e668832ef66a..ae2c2aace0d0 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -277,14 +277,14 @@ struct obs_kernel_param {
var = 1; \
return 0; \
} \
- __setup_param(str_on, parse_##var##_on, parse_##var##_on, 1); \
+ early_param(str_on, parse_##var##_on); \
\
static int __init parse_##var##_off(char *arg) \
{ \
var = 0; \
return 0; \
} \
- __setup_param(str_off, parse_##var##_off, parse_##var##_off, 1)
+ early_param(str_off, parse_##var##_off)
/* Relies on boot_command_line being set */
void __init parse_early_param(void);
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] init: clean up early_param_on_off() macro
2021-02-01 4:15 [PATCH] init: clean up early_param_on_off() macro Masahiro Yamada
@ 2021-02-01 9:27 ` Johan Hovold
2021-02-01 15:58 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2021-02-01 9:27 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kernel, Andrew Morton, Joe Perches, Miguel Ojeda, Nick Desaulniers
On Mon, Feb 01, 2021 at 01:15:32PM +0900, Masahiro Yamada wrote:
> Use early_param() to define early_param_on_off().
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> include/linux/init.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/init.h b/include/linux/init.h
> index e668832ef66a..ae2c2aace0d0 100644
> --- a/include/linux/init.h
> +++ b/include/linux/init.h
> @@ -277,14 +277,14 @@ struct obs_kernel_param {
> var = 1; \
> return 0; \
> } \
> - __setup_param(str_on, parse_##var##_on, parse_##var##_on, 1); \
> + early_param(str_on, parse_##var##_on); \
> \
> static int __init parse_##var##_off(char *arg) \
> { \
> var = 0; \
> return 0; \
> } \
> - __setup_param(str_off, parse_##var##_off, parse_##var##_off, 1)
> + early_param(str_off, parse_##var##_off)
>
> /* Relies on boot_command_line being set */
> void __init parse_early_param(void);
Looks good:
Reviewed-by: Johan Hovold <johan@kernel.org>
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] init: clean up early_param_on_off() macro
2021-02-01 4:15 [PATCH] init: clean up early_param_on_off() macro Masahiro Yamada
2021-02-01 9:27 ` Johan Hovold
@ 2021-02-01 15:58 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2021-02-01 15:58 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kernel, Andrew Morton, Joe Perches, Johan Hovold,
Miguel Ojeda, Nick Desaulniers
On Mon, Feb 1, 2021 at 5:15 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Use early_param() to define early_param_on_off().
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-01 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 4:15 [PATCH] init: clean up early_param_on_off() macro Masahiro Yamada
2021-02-01 9:27 ` Johan Hovold
2021-02-01 15:58 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®