* [PATCH] mmc: core: Use host instead of card argument to mmc_spi_send_csd()
@ 2021-02-01 5:55 Yue Hu
2021-02-08 12:06 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Yue Hu @ 2021-02-01 5:55 UTC (permalink / raw)
To: ulf.hansson; +Cc: linux-mmc, linux-kernel, huyue2, zhangwen, zbestahu
From: Yue Hu <huyue2@yulong.com>
Since mmc_send_cxd_data() does not care card if opcode is MMC_SEND_CSD.
Signed-off-by: Yue Hu <huyue2@yulong.com>
---
drivers/mmc/core/mmc_ops.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index baa6314..265d95e 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -296,7 +296,7 @@ int mmc_set_relative_addr(struct mmc_card *card)
return 0;
}
-static int mmc_spi_send_csd(struct mmc_card *card, u32 *csd)
+static int mmc_spi_send_csd(struct mmc_host *host, u32 *csd)
{
int ret, i;
__be32 *csd_tmp;
@@ -305,7 +305,7 @@ static int mmc_spi_send_csd(struct mmc_card *card, u32 *csd)
if (!csd_tmp)
return -ENOMEM;
- ret = mmc_send_cxd_data(card, card->host, MMC_SEND_CSD, csd_tmp, 16);
+ ret = mmc_send_cxd_data(NULL, host, MMC_SEND_CSD, csd_tmp, 16);
if (ret)
goto err;
@@ -320,7 +320,7 @@ static int mmc_spi_send_csd(struct mmc_card *card, u32 *csd)
int mmc_send_csd(struct mmc_card *card, u32 *csd)
{
if (mmc_host_is_spi(card->host))
- return mmc_spi_send_csd(card, csd);
+ return mmc_spi_send_csd(card->host, csd);
return mmc_send_cxd_native(card->host, card->rca << 16, csd,
MMC_SEND_CSD);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: core: Use host instead of card argument to mmc_spi_send_csd()
2021-02-01 5:55 [PATCH] mmc: core: Use host instead of card argument to mmc_spi_send_csd() Yue Hu
@ 2021-02-08 12:06 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2021-02-08 12:06 UTC (permalink / raw)
To: Yue Hu; +Cc: linux-mmc, Linux Kernel Mailing List, Yue Hu, zhangwen, zbestahu
On Mon, 1 Feb 2021 at 06:57, Yue Hu <zbestahu@gmail.com> wrote:
>
> From: Yue Hu <huyue2@yulong.com>
>
> Since mmc_send_cxd_data() does not care card if opcode is MMC_SEND_CSD.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/core/mmc_ops.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index baa6314..265d95e 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -296,7 +296,7 @@ int mmc_set_relative_addr(struct mmc_card *card)
> return 0;
> }
>
> -static int mmc_spi_send_csd(struct mmc_card *card, u32 *csd)
> +static int mmc_spi_send_csd(struct mmc_host *host, u32 *csd)
> {
> int ret, i;
> __be32 *csd_tmp;
> @@ -305,7 +305,7 @@ static int mmc_spi_send_csd(struct mmc_card *card, u32 *csd)
> if (!csd_tmp)
> return -ENOMEM;
>
> - ret = mmc_send_cxd_data(card, card->host, MMC_SEND_CSD, csd_tmp, 16);
> + ret = mmc_send_cxd_data(NULL, host, MMC_SEND_CSD, csd_tmp, 16);
> if (ret)
> goto err;
>
> @@ -320,7 +320,7 @@ static int mmc_spi_send_csd(struct mmc_card *card, u32 *csd)
> int mmc_send_csd(struct mmc_card *card, u32 *csd)
> {
> if (mmc_host_is_spi(card->host))
> - return mmc_spi_send_csd(card, csd);
> + return mmc_spi_send_csd(card->host, csd);
>
> return mmc_send_cxd_native(card->host, card->rca << 16, csd,
> MMC_SEND_CSD);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-08 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 5:55 [PATCH] mmc: core: Use host instead of card argument to mmc_spi_send_csd() Yue Hu
2021-02-08 12:06 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®