* [PATCH] nvme-pci: Mark Phison E16 (Corsair MP600) as IGNORE_DEV_SUBNQN
@ 2021-02-01 21:08 Claus Stovgaard
2021-02-02 0:11 ` Amy Parker
2021-02-02 9:49 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Claus Stovgaard @ 2021-02-01 21:08 UTC (permalink / raw)
To: linux-nvme
Cc: Claus Stovgaard, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-kernel
Tested both with Corsairs firmware 11.3 and 13.0 for the MP600 and both
have the issue as reported by the kernel.
nvme nvme0: missing or invalid SUBNQN field.
Signed-off-by: Claus Stovgaard <claus.stovgaard@gmail.com>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 81e6389b2042..41b1b0731cbd 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3242,6 +3242,8 @@ static const struct pci_device_id nvme_id_table[] = {
{ PCI_DEVICE(0x144d, 0xa822), /* Samsung PM1725a */
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+ { PCI_DEVICE(0x1987, 0x5016), /* Phison E16 (Corsair MP600) */
+ .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
{ PCI_DEVICE(0x1d1d, 0x1f1f), /* LighNVM qemu device */
.driver_data = NVME_QUIRK_LIGHTNVM, },
{ PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-pci: Mark Phison E16 (Corsair MP600) as IGNORE_DEV_SUBNQN
2021-02-01 21:08 [PATCH] nvme-pci: Mark Phison E16 (Corsair MP600) as IGNORE_DEV_SUBNQN Claus Stovgaard
@ 2021-02-02 0:11 ` Amy Parker
2021-02-02 9:49 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Amy Parker @ 2021-02-02 0:11 UTC (permalink / raw)
To: Claus Stovgaard
Cc: linux-nvme, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-kernel
On Mon, Feb 1, 2021 at 1:11 PM Claus Stovgaard
<claus.stovgaard@gmail.com> wrote:
>
> Tested both with Corsairs firmware 11.3 and 13.0 for the MP600 and both
> have the issue as reported by the kernel.
>
> nvme nvme0: missing or invalid SUBNQN field.
>
> Signed-off-by: Claus Stovgaard <claus.stovgaard@gmail.com>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 81e6389b2042..41b1b0731cbd 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3242,6 +3242,8 @@ static const struct pci_device_id nvme_id_table[] = {
> { PCI_DEVICE(0x144d, 0xa822), /* Samsung PM1725a */
> .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
> NVME_QUIRK_IGNORE_DEV_SUBNQN, },
> + { PCI_DEVICE(0x1987, 0x5016), /* Phison E16 (Corsair MP600) */
> + .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
> { PCI_DEVICE(0x1d1d, 0x1f1f), /* LighNVM qemu device */
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> --
> 2.26.2
>
Can't test this - don't have an MP600 of my own to test with - but it
should work just fine. If anyone else has an MP600 to throw at this
that'd be great.
Acked-by: Amy Parker <enbyamy@gmail.com>
Best regards,
Amy Parker
(she/her/hers)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-pci: Mark Phison E16 (Corsair MP600) as IGNORE_DEV_SUBNQN
2021-02-01 21:08 [PATCH] nvme-pci: Mark Phison E16 (Corsair MP600) as IGNORE_DEV_SUBNQN Claus Stovgaard
2021-02-02 0:11 ` Amy Parker
@ 2021-02-02 9:49 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-02-02 9:49 UTC (permalink / raw)
To: Claus Stovgaard
Cc: linux-nvme, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-kernel
Thanks,
applied to nvme-5.11.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-02 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 21:08 [PATCH] nvme-pci: Mark Phison E16 (Corsair MP600) as IGNORE_DEV_SUBNQN Claus Stovgaard
2021-02-02 0:11 ` Amy Parker
2021-02-02 9:49 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome