From: Avri Altman <avri.altman@wdc.com>
To: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
Daejun Park <daejun7.park@samsung.com>,
alim.akhtar@samsung.com, asutoshd@codeaurora.org,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <avi.shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
cang@codeaurora.org, stanley.chu@mediatek.com,
Avri Altman <avri.altman@wdc.com>
Subject: [PATCH v2 1/9] scsi: ufshpb: Cache HPB Control mode on init
Date: Tue, 2 Feb 2021 10:29:59 +0200 [thread overview]
Message-ID: <20210202083007.104050-2-avri.altman@wdc.com> (raw)
In-Reply-To: <20210202083007.104050-1-avri.altman@wdc.com>
We will use it later, when we'll need to differentiate between device
and host control modes.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
---
drivers/scsi/ufs/ufshcd.h | 2 ++
drivers/scsi/ufs/ufshpb.c | 8 +++++---
drivers/scsi/ufs/ufshpb.h | 2 ++
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 961fc5b77943..7aeb83b10c37 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -654,6 +654,7 @@ struct ufs_hba_variant_params {
* @srgn_size: device reported HPB sub-region size
* @slave_conf_cnt: counter to check all lu finished initialization
* @hpb_disabled: flag to check if HPB is disabled
+ * @control_mode: either host or device
*/
struct ufshpb_dev_info {
int num_lu;
@@ -661,6 +662,7 @@ struct ufshpb_dev_info {
int srgn_size;
atomic_t slave_conf_cnt;
bool hpb_disabled;
+ u8 control_mode;
};
#endif
diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 73e7b3ed04a4..46f6a7104e7e 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -1128,6 +1128,9 @@ static void ufshpb_lu_parameter_init(struct ufs_hba *hba,
(hpb->srgn_mem_size / HPB_ENTRY_SIZE));
hpb->pages_per_srgn = DIV_ROUND_UP(hpb->srgn_mem_size, PAGE_SIZE);
+
+ if (hpb_dev_info->control_mode == HPB_HOST_CONTROL)
+ hpb->is_hcm = true;
}
static int ufshpb_alloc_region_tbl(struct ufs_hba *hba, struct ufshpb_lu *hpb)
@@ -1694,10 +1697,9 @@ void ufshpb_get_dev_info(struct ufs_hba *hba, u8 *desc_buf)
{
struct ufshpb_dev_info *hpb_dev_info = &hba->ufshpb_dev;
int version;
- u8 hpb_mode;
- hpb_mode = desc_buf[DEVICE_DESC_PARAM_HPB_CONTROL];
- if (hpb_mode == HPB_HOST_CONTROL) {
+ hpb_dev_info->control_mode = desc_buf[DEVICE_DESC_PARAM_HPB_CONTROL];
+ if (hpb_dev_info->control_mode == HPB_HOST_CONTROL) {
dev_err(hba->dev, "%s: host control mode is not supported.\n",
__func__);
hpb_dev_info->hpb_disabled = true;
diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
index 2c43a03b66b6..afeb6365daf8 100644
--- a/drivers/scsi/ufs/ufshpb.h
+++ b/drivers/scsi/ufs/ufshpb.h
@@ -186,6 +186,8 @@ struct ufshpb_lu {
u32 entries_per_srgn_shift;
u32 pages_per_srgn;
+ bool is_hcm;
+
struct ufshpb_stats stats;
struct kmem_cache *map_req_cache;
--
2.25.1
next prev parent reply other threads:[~2021-02-02 8:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 8:29 [PATCH v2 0/9] Add Host control mode to HPB Avri Altman
2021-02-02 8:29 ` Avri Altman [this message]
2021-02-02 8:30 ` [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-02-02 11:13 ` Greg KH
2021-02-02 11:24 ` Avri Altman
2021-02-02 11:51 ` Greg KH
2021-02-02 11:54 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 3/9] scsi: ufshpb: Add region's reads counter Avri Altman
2021-02-02 11:15 ` Greg KH
2021-02-02 11:23 ` Avri Altman
2021-02-02 11:51 ` Greg KH
2021-02-02 11:16 ` Greg KH
2021-02-02 11:22 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 4/9] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-02-02 8:30 ` [PATCH v2 5/9] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-02-02 8:30 ` [PATCH v2 6/9] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-02-08 6:34 ` Can Guo
2021-02-08 7:50 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 7/9] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-02-02 8:30 ` [PATCH v2 8/9] scsi: ufshpb: Add support for host control mode Avri Altman
2021-02-02 8:30 ` [PATCH v2 9/9] scsi: ufshpb: Make host mode parameters configurable Avri Altman
2021-02-02 11:17 ` Greg KH
2021-02-02 11:21 ` Avri Altman
[not found] ` <CGME20210202112157epcas2p3b04677e1380e0fa2c3f38217dfcba8bf@epcms2p8>
2021-02-04 0:48 ` Daejun Park
2021-02-02 11:18 ` Greg KH
2021-02-02 11:20 ` Avri Altman
2021-02-05 11:36 ` [PATCH v2 0/9] Add Host control mode to HPB Bean Huo
2021-02-05 11:43 ` Bean Huo
2021-02-07 14:07 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202083007.104050-2-avri.altman@wdc.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avi.shchislowski@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®