mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mailbox: sprd: correct definition of SPRD_OUTBOX_FIFO_FULL
@ 2021-02-04  8:18 Chunyan Zhang
  2021-02-04 10:59 ` Baolin Wang
  0 siblings, 1 reply; 2+ messages in thread
From: Chunyan Zhang @ 2021-02-04  8:18 UTC (permalink / raw)
  To: Jassi Brar
  Cc: Baolin Wang, linux-kernel, Orson Zhai, Chunyan Zhang,
	Chunyan Zhang, Magnum Shan, Haidong Yao

From: Magnum Shan <magnum.shan@unisoc.com>

According to the specification, bit[2] represents SPRD_OUTBOX_FIFO_FULL,
not bit[0], so correct it.

Fixes: ca27fc26cd22 ("mailbox: sprd: Add Spreadtrum mailbox driver")
Signed-off-by: Magnum Shan <magnum.shan@unisoc.com>
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
---
 drivers/mailbox/sprd-mailbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/sprd-mailbox.c b/drivers/mailbox/sprd-mailbox.c
index f6fab24ae8a9..4c325301a2fe 100644
--- a/drivers/mailbox/sprd-mailbox.c
+++ b/drivers/mailbox/sprd-mailbox.c
@@ -35,7 +35,7 @@
 #define SPRD_MBOX_IRQ_CLR			BIT(0)
 
 /* Bit and mask definiation for outbox's SPRD_MBOX_FIFO_STS register */
-#define SPRD_OUTBOX_FIFO_FULL			BIT(0)
+#define SPRD_OUTBOX_FIFO_FULL			BIT(2)
 #define SPRD_OUTBOX_FIFO_WR_SHIFT		16
 #define SPRD_OUTBOX_FIFO_RD_SHIFT		24
 #define SPRD_OUTBOX_FIFO_POS_MASK		GENMASK(7, 0)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mailbox: sprd: correct definition of SPRD_OUTBOX_FIFO_FULL
  2021-02-04  8:18 [PATCH] mailbox: sprd: correct definition of SPRD_OUTBOX_FIFO_FULL Chunyan Zhang
@ 2021-02-04 10:59 ` Baolin Wang
  0 siblings, 0 replies; 2+ messages in thread
From: Baolin Wang @ 2021-02-04 10:59 UTC (permalink / raw)
  To: Chunyan Zhang
  Cc: Jassi Brar, LKML, Orson Zhai, Chunyan Zhang, Magnum Shan, Haidong Yao

On Thu, Feb 4, 2021 at 4:18 PM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>
> From: Magnum Shan <magnum.shan@unisoc.com>
>
> According to the specification, bit[2] represents SPRD_OUTBOX_FIFO_FULL,
> not bit[0], so correct it.
>
> Fixes: ca27fc26cd22 ("mailbox: sprd: Add Spreadtrum mailbox driver")
> Signed-off-by: Magnum Shan <magnum.shan@unisoc.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>

LGTM.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
>  drivers/mailbox/sprd-mailbox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/sprd-mailbox.c b/drivers/mailbox/sprd-mailbox.c
> index f6fab24ae8a9..4c325301a2fe 100644
> --- a/drivers/mailbox/sprd-mailbox.c
> +++ b/drivers/mailbox/sprd-mailbox.c
> @@ -35,7 +35,7 @@
>  #define SPRD_MBOX_IRQ_CLR                      BIT(0)
>
>  /* Bit and mask definiation for outbox's SPRD_MBOX_FIFO_STS register */
> -#define SPRD_OUTBOX_FIFO_FULL                  BIT(0)
> +#define SPRD_OUTBOX_FIFO_FULL                  BIT(2)
>  #define SPRD_OUTBOX_FIFO_WR_SHIFT              16
>  #define SPRD_OUTBOX_FIFO_RD_SHIFT              24
>  #define SPRD_OUTBOX_FIFO_POS_MASK              GENMASK(7, 0)
> --
> 2.25.1
>


-- 
Baolin Wang

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-04 11:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04  8:18 [PATCH] mailbox: sprd: correct definition of SPRD_OUTBOX_FIFO_FULL Chunyan Zhang
2021-02-04 10:59 ` Baolin Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®