mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Dan Williams <dan.j.williams@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v2 0/5] dax-device: Some cleanups
Date: Fri,  5 Feb 2021 23:28:37 +0100	[thread overview]
Message-ID: <20210205222842.34896-1-uwe@kleine-koenig.org> (raw)

Hello,

I didn't get any feedback for the (implicit) v1 of this series that
started with Message-Id: 20210127230124.109522-1-uwe@kleine-koenig.org,
but I identified a few improvements myself:

 - Use "dax-device" consistently as a prefix
 - Instead of requiring a .remove callback, make it explicitly
   optional. (Drop checking for .remove from former patch 1, introduce
   new patch "Properly handle drivers without remove callback")
 - The new patch about remove being optional allows to simplify one of
   the two dax drivers which is implemented in patch 4
 - Patch 5 got a bit smaller because we now have one driver less with a
   remove callback.
 - Added Andrew to To: as he merged dax drivers in the past.

Andrew: Assuming you consider these patches useful, would you please
care for merging them?

Best regards
Uwe

Uwe Kleine-König (5):
  dax-device: Prevent registering drivers without probe callback
  dax-device: Properly handle drivers without remove callback
  dax-device: Fix error path in dax_driver_register
  dax-device: Drop an empty .remove callback
  dax-device: Make remove callback return void

 drivers/dax/bus.c    | 22 ++++++++++++++++++++--
 drivers/dax/bus.h    |  2 +-
 drivers/dax/device.c |  8 +-------
 drivers/dax/kmem.c   |  7 ++-----
 4 files changed, 24 insertions(+), 15 deletions(-)


base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
-- 
2.29.2


             reply	other threads:[~2021-02-06  3:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 22:28 Uwe Kleine-König [this message]
2021-02-05 22:28 ` [PATCH v2 1/5] dax-device: Prevent registering drivers without probe callback Uwe Kleine-König
2021-02-05 22:28 ` [PATCH v2 2/5] dax-device: Properly handle drivers without remove callback Uwe Kleine-König
2021-02-05 22:28 ` [PATCH v2 3/5] dax-device: Fix error path in dax_driver_register Uwe Kleine-König
2021-02-05 22:28 ` [PATCH v2 4/5] dax-device: Drop an empty .remove callback Uwe Kleine-König
2021-02-05 22:28 ` [PATCH v2 5/5] dax-device: Make remove callback return void Uwe Kleine-König
2021-02-17  3:48 ` [PATCH v2 0/5] dax-device: Some cleanups Dan Williams
2021-02-17  3:55   ` Dan Williams
2021-02-17  6:39     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205222842.34896-1-uwe@kleine-koenig.org \
    --to=uwe@kleine-koenig.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®