* [PATCH] memory: ti-emif-pm: Drop of_match_ptr from of_device_id table
@ 2021-02-06 11:13 Krzysztof Kozlowski
2021-02-06 22:08 ` Nathan Chancellor
2021-02-08 17:16 ` (subset) " Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-06 11:13 UTC (permalink / raw)
To: Santosh Shilimkar, Krzysztof Kozlowski, Nathan Chancellor,
Nick Desaulniers, linux-kernel, clang-built-linux
Cc: kernel test robot
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might be not relevant here). This
fixes compile warning (!CONFIG_OF with clang):
drivers/memory/ti-emif-pm.c:238:34: warning:
unused variable 'ti_emif_of_match' [-Wunused-const-variable]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/memory/ti-emif-pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/ti-emif-pm.c b/drivers/memory/ti-emif-pm.c
index 6c747c1e98cb..179fec2da56d 100644
--- a/drivers/memory/ti-emif-pm.c
+++ b/drivers/memory/ti-emif-pm.c
@@ -340,7 +340,7 @@ static struct platform_driver ti_emif_driver = {
.remove = ti_emif_remove,
.driver = {
.name = KBUILD_MODNAME,
- .of_match_table = of_match_ptr(ti_emif_of_match),
+ .of_match_table = ti_emif_of_match,
.pm = &ti_emif_pm_ops,
},
};
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] memory: ti-emif-pm: Drop of_match_ptr from of_device_id table
2021-02-06 11:13 [PATCH] memory: ti-emif-pm: Drop of_match_ptr from of_device_id table Krzysztof Kozlowski
@ 2021-02-06 22:08 ` Nathan Chancellor
2021-02-08 17:16 ` (subset) " Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-02-06 22:08 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Santosh Shilimkar, Nick Desaulniers, linux-kernel,
clang-built-linux, kernel test robot
On Sat, Feb 06, 2021 at 12:13:43PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might be not relevant here). This
> fixes compile warning (!CONFIG_OF with clang):
>
> drivers/memory/ti-emif-pm.c:238:34: warning:
> unused variable 'ti_emif_of_match' [-Wunused-const-variable]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Yes, this seems to be how everyone is dealing with this warning:
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/memory/ti-emif-pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/ti-emif-pm.c b/drivers/memory/ti-emif-pm.c
> index 6c747c1e98cb..179fec2da56d 100644
> --- a/drivers/memory/ti-emif-pm.c
> +++ b/drivers/memory/ti-emif-pm.c
> @@ -340,7 +340,7 @@ static struct platform_driver ti_emif_driver = {
> .remove = ti_emif_remove,
> .driver = {
> .name = KBUILD_MODNAME,
> - .of_match_table = of_match_ptr(ti_emif_of_match),
> + .of_match_table = ti_emif_of_match,
> .pm = &ti_emif_pm_ops,
> },
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: (subset) [PATCH] memory: ti-emif-pm: Drop of_match_ptr from of_device_id table
2021-02-06 11:13 [PATCH] memory: ti-emif-pm: Drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2021-02-06 22:08 ` Nathan Chancellor
@ 2021-02-08 17:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-08 17:16 UTC (permalink / raw)
To: Nick Desaulniers, Nathan Chancellor, Santosh Shilimkar,
linux-kernel, clang-built-linux, Krzysztof Kozlowski
Cc: kernel test robot
On Sat, 6 Feb 2021 12:13:43 +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might be not relevant here). This
> fixes compile warning (!CONFIG_OF with clang):
>
> drivers/memory/ti-emif-pm.c:238:34: warning:
> unused variable 'ti_emif_of_match' [-Wunused-const-variable]
Applied, thanks!
[1/1] memory: ti-emif-pm: Drop of_match_ptr from of_device_id table
commit: 62c290a6784af56fa1438f6d2688cd9360c840f1
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-08 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-06 11:13 [PATCH] memory: ti-emif-pm: Drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2021-02-06 22:08 ` Nathan Chancellor
2021-02-08 17:16 ` (subset) " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®