* [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover
@ 2021-02-08 21:43 Sedat Dilek
2021-02-08 22:01 ` Kyle Huey
0 siblings, 1 reply; 3+ messages in thread
From: Sedat Dilek @ 2021-02-08 21:43 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, Gabriel Krisman Bertazi, Kees Cook,
Andy Lutomirski, Frederic Weisbecker, Sedat Dilek,
Peter Zijlstra (Intel),
Jens Axboe, linux-kernel
Cc: Kyle Huey
After commit 6342adcaa683 ("entry: Ensure trap after single-step on
system call return") a _TIF_SINGLESTEP define is obsolete for arch/x86.
So, remove the leftover in arch/x86/include/asm/thread_info.h file.
Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return"
CC: Kyle Huey <me@kylehuey.com>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
arch/x86/include/asm/thread_info.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
index 0d751d5da702..8861967e0305 100644
--- a/arch/x86/include/asm/thread_info.h
+++ b/arch/x86/include/asm/thread_info.h
@@ -101,7 +101,6 @@ struct thread_info {
#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
-#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
#define _TIF_SSBD (1 << TIF_SSBD)
#define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
#define _TIF_SPEC_FORCE_UPDATE (1 << TIF_SPEC_FORCE_UPDATE)
--
2.30.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover
2021-02-08 21:43 [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover Sedat Dilek
@ 2021-02-08 22:01 ` Kyle Huey
2021-02-13 19:19 ` Sedat Dilek
0 siblings, 1 reply; 3+ messages in thread
From: Kyle Huey @ 2021-02-08 22:01 UTC (permalink / raw)
To: Sedat Dilek
Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
H. Peter Anvin, Gabriel Krisman Bertazi, Kees Cook,
Andy Lutomirski, Frederic Weisbecker, Peter Zijlstra (Intel),
Jens Axboe, open list
Looks good to me.
- Kyle
On Mon, Feb 8, 2021 at 1:43 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> After commit 6342adcaa683 ("entry: Ensure trap after single-step on
> system call return") a _TIF_SINGLESTEP define is obsolete for arch/x86.
>
> So, remove the leftover in arch/x86/include/asm/thread_info.h file.
>
> Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return"
> CC: Kyle Huey <me@kylehuey.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> ---
> arch/x86/include/asm/thread_info.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> index 0d751d5da702..8861967e0305 100644
> --- a/arch/x86/include/asm/thread_info.h
> +++ b/arch/x86/include/asm/thread_info.h
> @@ -101,7 +101,6 @@ struct thread_info {
> #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
> #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
> #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
> -#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
> #define _TIF_SSBD (1 << TIF_SSBD)
> #define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
> #define _TIF_SPEC_FORCE_UPDATE (1 << TIF_SPEC_FORCE_UPDATE)
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover
2021-02-08 22:01 ` Kyle Huey
@ 2021-02-13 19:19 ` Sedat Dilek
0 siblings, 0 replies; 3+ messages in thread
From: Sedat Dilek @ 2021-02-13 19:19 UTC (permalink / raw)
To: Kyle Huey
Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
H. Peter Anvin, Gabriel Krisman Bertazi, Kees Cook,
Andy Lutomirski, Frederic Weisbecker, Peter Zijlstra (Intel),
Jens Axboe, open list
On Mon, Feb 8, 2021 at 11:01 PM Kyle Huey <me@kylehuey.com> wrote:
>
> Looks good to me.
>
Any other comments on this patch v2?
Thanks.
- Sedat -
> - Kyle
>
> On Mon, Feb 8, 2021 at 1:43 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> > After commit 6342adcaa683 ("entry: Ensure trap after single-step on
> > system call return") a _TIF_SINGLESTEP define is obsolete for arch/x86.
> >
> > So, remove the leftover in arch/x86/include/asm/thread_info.h file.
> >
> > Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return"
> > CC: Kyle Huey <me@kylehuey.com>
> > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> > ---
> > arch/x86/include/asm/thread_info.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> > index 0d751d5da702..8861967e0305 100644
> > --- a/arch/x86/include/asm/thread_info.h
> > +++ b/arch/x86/include/asm/thread_info.h
> > @@ -101,7 +101,6 @@ struct thread_info {
> > #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
> > #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
> > #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
> > -#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
> > #define _TIF_SSBD (1 << TIF_SSBD)
> > #define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
> > #define _TIF_SPEC_FORCE_UPDATE (1 << TIF_SPEC_FORCE_UPDATE)
> > --
> > 2.30.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-13 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 21:43 [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover Sedat Dilek
2021-02-08 22:01 ` Kyle Huey
2021-02-13 19:19 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®