From: James Clark <james.clark@arm.com>
To: coresight@lists.linaro.org
Cc: al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org,
James Clark <james.clark@arm.com>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Leo Yan <leo.yan@linaro.org>, Mike Leach <mike.leach@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 0/5] Split Coresight decode by aux records
Date: Tue, 9 Feb 2021 11:58:52 +0200 [thread overview]
Message-ID: <20210209095857.28419-1-james.clark@arm.com> (raw)
The following patches fix opening perf.data files that have timestamps
(ordered data), aren't recorded with --per-thread, and that have
discontinuous data in a single aux trace buffer.
I have some open questions:
* Can cs_etm__update_queues() be removed from cs_etm__flush_events()?
* Why does the second commit start making some files process correctly?
* Is it ok to wait for the flush to start processing? Previously
processing happened when the first aux record was delivered to
cs_etm__process_event().
* Do the aux records need to be saved into a new buffer or can they
be pulled from elsewhere?
I also have some further changes to make to make per-thread mode work
where the cpu field of the sample is set to -1. And when there are
no timestamps cs_etm__process_timeless_queues() is used, which is a
completely different code path.
Thanks
James
James Clark (5):
perf cs-etm: Split up etm queue setup function
perf cs-etm: Only search timestamp in current sample's queue.
perf cs-etm: Save aux records in each etm queue
perf cs-etm: don't process queues until cs_etm__flush_events
perf cs-etm: split decode by aux records.
tools/perf/util/cs-etm.c | 200 +++++++++++++++++++++++----------------
1 file changed, 121 insertions(+), 79 deletions(-)
--
2.28.0
next reply other threads:[~2021-02-09 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 9:58 James Clark [this message]
2021-02-09 9:58 ` [RFC PATCH 1/5] perf cs-etm: Split up etm queue setup function James Clark
2021-02-09 9:58 ` [RFC PATCH 2/5] perf cs-etm: Only search timestamp in current sample's queue James Clark
2021-02-09 9:58 ` [RFC PATCH 3/5] perf cs-etm: Save aux records in each etm queue James Clark
2021-02-09 9:58 ` [RFC PATCH 4/5] perf cs-etm: don't process queues until cs_etm__flush_events James Clark
2021-02-09 9:58 ` [RFC PATCH 5/5] perf cs-etm: split decode by aux records James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209095857.28419-1-james.clark@arm.com \
--to=james.clark@arm.com \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=branislav.rankov@arm.com \
--cc=coresight@lists.linaro.org \
--cc=denik@chromium.org \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®