From: James Clark <james.clark@arm.com>
To: coresight@lists.linaro.org
Cc: al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org,
James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 4/5] perf cs-etm: don't process queues until cs_etm__flush_events
Date: Tue, 9 Feb 2021 11:58:56 +0200 [thread overview]
Message-ID: <20210209095857.28419-5-james.clark@arm.com> (raw)
In-Reply-To: <20210209095857.28419-1-james.clark@arm.com>
To make sure processing happens in the correct order, queue processing
shouldn't start until every aux queue has had its first timestamp found.
Now that we're only searching for timestamps within each aux record, we
need to wait until all aux records are delivered before starting the
processing.
Signed-off-by: James Clark <james.clark@arm.com>
---
tools/perf/util/cs-etm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index efe418a7c82e..0aaa1f6d2822 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -2394,10 +2394,6 @@ static int cs_etm__process_event(struct perf_session *session,
else if (event->header.type == PERF_RECORD_SWITCH_CPU_WIDE)
return cs_etm__process_switch_cpu_wide(etm, event);
- if (!etm->timeless_decoding &&
- event->header.type == PERF_RECORD_AUX)
- return cs_etm__process_queues(etm);
-
return 0;
}
--
2.28.0
next prev parent reply other threads:[~2021-02-09 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 9:58 [RFC PATCH 0/5] Split Coresight decode by aux records James Clark
2021-02-09 9:58 ` [RFC PATCH 1/5] perf cs-etm: Split up etm queue setup function James Clark
2021-02-09 9:58 ` [RFC PATCH 2/5] perf cs-etm: Only search timestamp in current sample's queue James Clark
2021-02-09 9:58 ` [RFC PATCH 3/5] perf cs-etm: Save aux records in each etm queue James Clark
2021-02-09 9:58 ` James Clark [this message]
2021-02-09 9:58 ` [RFC PATCH 5/5] perf cs-etm: split decode by aux records James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209095857.28419-5-james.clark@arm.com \
--to=james.clark@arm.com \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=branislav.rankov@arm.com \
--cc=coresight@lists.linaro.org \
--cc=denik@chromium.org \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®