[PATCH 1/3] MAINTAINERS: power: supply: add entry for S3C ADC battery driver

[PATCH 1/3] MAINTAINERS: power: supply: add entry for S3C ADC battery driver

[Krzysztof Kozlowski]

The S3C ADC battery driver is a very old piece of code but still used by
(very old as well) S3C24xx platforms (iPAQ h1930/h1940/rx1950).
Currently the header file is not covered by maintainers file, so it
might look abandoned.  Add a new entry for entire S3C ADC battery driver
with Krzysztof Kozlowski as maintainer (as Krzysztof maintains still
Samsung S3C24xx platform) to indicate that some basic review can take
place.

However considering that the S3C24xx platform is quite old with only few
users currently and Krzysztof does not have the actual hardware, let's
mark the driver as "Odd fixes".

Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5f7aa507b812..6abf7cc513df 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15614,6 +15614,13 @@ S:	Supported
 W:	http://www.ibm.com/developerworks/linux/linux390/
 F:	drivers/s390/scsi/zfcp_*
 
+S3C ADC BATTERY DRIVER
+M:	Krzysztof Kozlowski <krzk@kernel.org>
+L:	linux-samsung-soc@vger.kernel.org
+S:	Odd Fixes
+F:	drivers/power/supply/s3c_adc_battery.c
+F:	include/linux/s3c_adc_battery.h
+
 S3C24XX SD/MMC Driver
 M:	Ben Dooks <ben-linux@fluff.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-- 
2.25.1

[PATCH 2/3] power: supply: s3c_adc_battery: add SPDX license identifier

[Krzysztof Kozlowski]

Add SPDX license identifier and replace license boilerplate.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/power/supply/s3c_adc_battery.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c
index a2addc24ee8b..de98aea53a24 100644
--- a/drivers/power/supply/s3c_adc_battery.c
+++ b/drivers/power/supply/s3c_adc_battery.c
@@ -1,13 +1,8 @@
-/*
- *	iPAQ h1930/h1940/rx1950 battery controller driver
- *	Copyright (c) Vasily Khoruzhick
- *	Based on h1940_battery.c by Arnaud Patard
- *
- * This file is subject to the terms and conditions of the GNU General Public
- * License.  See the file COPYING in the main directory of this archive for
- * more details.
- *
- */
+// SPDX-License-Identifier: GPL-2.0
+//
+// iPAQ h1930/h1940/rx1950 battery controller driver
+// Copyright (c) Vasily Khoruzhick
+// Based on h1940_battery.c by Arnaud Patard
 
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
-- 
2.25.1

[PATCH 3/3] power: supply: s3c_adc_battery: remove unused pdata in suspend/resume

[Krzysztof Kozlowski]

The "pdata" local variable is not used in suspend/resume handlers since
commit 7776bcd241e0 ("power: supply: s3c-adc-battery: Convert to GPIO
descriptors"):

    drivers/power/supply/s3c_adc_battery.c: In function ‘s3c_adc_bat_suspend’:
    drivers/power/supply/s3c_adc_battery.c:405:28: warning: unused variable ‘pdata’ [-Wunused-variable]

    drivers/power/supply/s3c_adc_battery.c: In function ‘s3c_adc_bat_resume’:
    drivers/power/supply/s3c_adc_battery.c:422:28: warning: unused variable ‘pdata’ [-Wunused-variable]

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/power/supply/s3c_adc_battery.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c
index de98aea53a24..dc700066d7bc 100644
--- a/drivers/power/supply/s3c_adc_battery.c
+++ b/drivers/power/supply/s3c_adc_battery.c
@@ -402,8 +402,6 @@ static int s3c_adc_bat_remove(struct platform_device *pdev)
 static int s3c_adc_bat_suspend(struct platform_device *pdev,
 	pm_message_t state)
 {
-	struct s3c_adc_bat_pdata *pdata = pdev->dev.platform_data;
-
 	if (main_bat.charge_finished) {
 		if (device_may_wakeup(&pdev->dev))
 			enable_irq_wake(
@@ -419,8 +417,6 @@ static int s3c_adc_bat_suspend(struct platform_device *pdev,
 
 static int s3c_adc_bat_resume(struct platform_device *pdev)
 {
-	struct s3c_adc_bat_pdata *pdata = pdev->dev.platform_data;
-
 	if (main_bat.charge_finished) {
 		if (device_may_wakeup(&pdev->dev))
 			disable_irq_wake(
-- 
2.25.1

Re: [PATCH 1/3] MAINTAINERS: power: supply: add entry for S3C ADC battery driver

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

Hi,

On Wed, Feb 10, 2021 at 06:21:06PM +0100, Krzysztof Kozlowski wrote:
> The S3C ADC battery driver is a very old piece of code but still used by
> (very old as well) S3C24xx platforms (iPAQ h1930/h1940/rx1950).
> Currently the header file is not covered by maintainers file, so it
> might look abandoned.  Add a new entry for entire S3C ADC battery driver
> with Krzysztof Kozlowski as maintainer (as Krzysztof maintains still
> Samsung S3C24xx platform) to indicate that some basic review can take
> place.
> 
> However considering that the S3C24xx platform is quite old with only few
> users currently and Krzysztof does not have the actual hardware, let's
> mark the driver as "Odd fixes".
> 
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Thanks, much appreciated. I queued this series some time ago, but
forgot to send a notification.

-- Sebastian

>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5f7aa507b812..6abf7cc513df 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15614,6 +15614,13 @@ S:	Supported
>  W:	http://www.ibm.com/developerworks/linux/linux390/
>  F:	drivers/s390/scsi/zfcp_*
>  
> +S3C ADC BATTERY DRIVER
> +M:	Krzysztof Kozlowski <krzk@kernel.org>
> +L:	linux-samsung-soc@vger.kernel.org
> +S:	Odd Fixes
> +F:	drivers/power/supply/s3c_adc_battery.c
> +F:	include/linux/s3c_adc_battery.h
> +
>  S3C24XX SD/MMC Driver
>  M:	Ben Dooks <ben-linux@fluff.org>
>  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]