From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH 1/2] power: supply: bq25980: Applies multiple fixes brought on
Date: Wed, 10 Feb 2021 21:38:44 +0100 [thread overview]
Message-ID: <20210210203844.pg2646qbnclth7zx@kozik-lap> (raw)
In-Reply-To: <8f952bd9-1849-af7e-d54f-b897c653a126@ti.com>
On Wed, Feb 10, 2021 at 01:50:03PM -0600, Ricardo Rivera-Matos wrote:
> Krzysztof,
>
> On 2/10/21 2:20 AM, Krzysztof Kozlowski wrote:
> > On Wed, 10 Feb 2021 at 00:52, Ricardo Rivera-Matos
> > <r-rivera-matos@ti.com> wrote:
> > > fix: corrects various register step size and offset values
> > >
> > > fix: corrects bq25980_get_input_curr_lim() and bq25980_set_input_curr_lim()
> > >
> > > fix: corrects bq25980_get_const_charge_curr() and bq25980_set_const_charge_curr()
> > >
> > > fix: corrects BQ25960_BATOVP_MIN_uV, BQ25960_BATOVP_OFFSET_uV,
> > >
> > > BQ25960_BATOVP_STEP_uV, and BQ25960_BATOVP_MAX_uV
> > >
> > > fix: corrects busocp_sc_min and busocp_byp_min members
> > >
> > > fix: removes unnecessary polarity check from bq25980_get_adc_ibus()
> > >
> > > fix: removes unnecessary polarity check from bq25980_get_adc_ibat()
> > >
> > > fix: clamps ibat_adc to match datasheet change
> > Thanks for the patch.
> >
> > Only one fix at a time and please exactly describe what is being fixed
> > using proper sentences (starting with capital letter, ending with a
> > full stop... and usually description needs multiple of such
> > sentences). You add here multiple changes without proper description
> > of a problem being fixed. This is not the correct style of a patch.
> ACK, this patch is meant to implement changes brought on by a new datasheet
> revision.
Only one "fix" in commit msg mentions datasheet.
> The revision tweaked the register step size and offset values to
> improve the accuracy. I can rebase and reword the patch if that works for
> you.
Yes, please. "corrects bq25980_get_input_curr_lim() and
bq25980_set_input_curr_lim()" tells me absolutely nothing what was wrong
and how it's get corrected.
Best regards,
Krzysztof
prev parent reply other threads:[~2021-02-10 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 23:05 Ricardo Rivera-Matos
2021-02-09 23:05 ` [PATCH 2/2] power: supply: bq25980: Moves properties from battery node Ricardo Rivera-Matos
2021-02-10 8:23 ` Krzysztof Kozlowski
2021-02-10 19:51 ` [EXTERNAL] " Ricardo Rivera-Matos
2021-02-10 8:20 ` [PATCH 1/2] power: supply: bq25980: Applies multiple fixes brought on Krzysztof Kozlowski
2021-02-10 19:50 ` [EXTERNAL] " Ricardo Rivera-Matos
2021-02-10 20:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210203844.pg2646qbnclth7zx@kozik-lap \
--to=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=r-rivera-matos@ti.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®