From: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <sre@kernel.org>, <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH 2/2] power: supply: bq25980: Moves properties from battery node
Date: Wed, 10 Feb 2021 13:51:31 -0600 [thread overview]
Message-ID: <e815f46c-d035-b9db-0239-dba81ad8e02b@ti.com> (raw)
In-Reply-To: <CAJKOXPeqd7iMU+gVC-xT-MY6YKXrB88gsCyd9M0NX=wCtyWrmA@mail.gmail.com>
On 2/10/21 2:23 AM, Krzysztof Kozlowski wrote:
> On Wed, 10 Feb 2021 at 00:52, Ricardo Rivera-Matos
> <r-rivera-matos@ti.com> wrote:
>> fix: exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT on the
>>
>> charger node
> Why is this a fix? Why is exposing this property wrong? What is the
> problem here? Why do you start sentences with a small letter? Your
> commit message should answer such questions.
ACK, I will rebase and reword this commit message
>
> Best regards,
> Krzysztof
Best Regards,
Ricardo
next prev parent reply other threads:[~2021-02-10 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 23:05 [PATCH 1/2] power: supply: bq25980: Applies multiple fixes brought on Ricardo Rivera-Matos
2021-02-09 23:05 ` [PATCH 2/2] power: supply: bq25980: Moves properties from battery node Ricardo Rivera-Matos
2021-02-10 8:23 ` Krzysztof Kozlowski
2021-02-10 19:51 ` Ricardo Rivera-Matos [this message]
2021-02-10 8:20 ` [PATCH 1/2] power: supply: bq25980: Applies multiple fixes brought on Krzysztof Kozlowski
2021-02-10 19:50 ` [EXTERNAL] " Ricardo Rivera-Matos
2021-02-10 20:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e815f46c-d035-b9db-0239-dba81ad8e02b@ti.com \
--to=r-rivera-matos@ti.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®