* Re: [PATCH v3 RESEND] MIPS: Make check condition for SDBBP more readable
[not found] <1612945826-4099-1-git-send-email-yangtiezhu@loongson.cn>
@ 2021-02-11 10:20 ` Thomas Bogendoerfer
0 siblings, 0 replies; only message in thread
From: Thomas Bogendoerfer @ 2021-02-11 10:20 UTC (permalink / raw)
To: Tiezhu Yang; +Cc: linux-mips, linux-kernel, Xuefeng Li
On Wed, Feb 10, 2021 at 04:30:26PM +0800, Tiezhu Yang wrote:
> According to MIPS EJTAG Specification [1], a Debug Breakpoint
> exception occurs when an SDBBP instruction is executed, the
> CP0_DEBUG bit DBp indicates that a Debug Breakpoint exception
> occurred.
>
> When I read the original code, it looks a little confusing
> at first glance, just check bit DBp for SDBBP to make the
> code more readable, it will be much easier to understand.
>
> [1] http://www.t-es-t.hu/download/mips/md00047f.pdf
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>
> RESEND due to send to mail list failed.
>
> v3: update the commit message and modify the patch subject
>
> v2: add MIPS_DEBUG_DBP definition
>
> arch/mips/include/asm/mipsregs.h | 4 ++++
> arch/mips/kernel/genex.S | 4 ++--
> 2 files changed, 6 insertions(+), 2 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] only message in thread