From: Mark Brown <broonie@kernel.org>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Axel Lin <axel.lin@ingics.com>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Robin Gong <yibin.gong@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] regulator: pca9450: Add SD_VSEL GPIO for LDO5
Date: Thu, 11 Feb 2021 13:04:06 +0000 [thread overview]
Message-ID: <20210211130406.GC5217@sirena.org.uk> (raw)
In-Reply-To: <20210211105534.38972-1-frieder.schrempf@kontron.de>
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
On Thu, Feb 11, 2021 at 11:55:28AM +0100, Schrempf Frieder wrote:
> + if (IS_ERR(pca9450->sd_vsel_gpio)) {
> + dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n");
Not critical but it's generally better to display the error code when
logging an error to aid in diagnostics.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-11 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 10:55 Schrempf Frieder
2021-02-11 10:55 ` [PATCH 2/3] dt-bindings: regulator: pca9450: Add sd-vsel GPIO Schrempf Frieder
2021-02-11 10:55 ` [PATCH 3/3] regulator: pca9450: Enable system reset on WDOG_B assertion Schrempf Frieder
2021-02-11 13:04 ` Mark Brown [this message]
2021-02-11 15:39 ` [PATCH 1/3] regulator: pca9450: Add SD_VSEL GPIO for LDO5 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211130406.GC5217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=frieder.schrempf@kontron.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®