From: Vincent Donnefort <vincent.donnefort@arm.com>
To: Quentin Perret <qperret@google.com>
Cc: peterz@infradead.org, mingo@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
linux-kernel@vger.kernel.org, patrick.bellasi@matbug.net,
valentin.schneider@arm.com
Subject: Re: [PATCH] sched/fair: Fix task utilization accountability in cpu_util_next()
Date: Mon, 22 Feb 2021 16:39:47 +0000 [thread overview]
Message-ID: <20210222163947.GB225035@e124901.cambridge.arm.com> (raw)
In-Reply-To: <YDPajlnvgkonocpp@google.com>
On Mon, Feb 22, 2021 at 04:23:42PM +0000, Quentin Perret wrote:
> On Monday 22 Feb 2021 at 15:58:56 (+0000), Quentin Perret wrote:
> > But in any case, if we're going to address this, I'm still not sure this
> > patch will be what we want. As per my first comment we need to keep the
> > frequency estimation right.
>
> Totally untested, but I think in principle you would like something like
> the snippet below. Would that work?
You preempted my previous email :)
Yeah, that looks like what we want, I'll give a try.
Thanks,
--
Vincent.
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 04a3ce20da67..6594d875c6ac 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -6534,8 +6534,13 @@ compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
> * its pd list and will not be accounted by compute_energy().
> */
> for_each_cpu_and(cpu, pd_mask, cpu_online_mask) {
> - unsigned long cpu_util, util_cfs = cpu_util_next(cpu, p, dst_cpu);
> + unsigned long util_freq = cpu_util_next(cpu, p, dst_cpu);
> + unsigned long util_running = cpu_util_without(cpu, p);
> struct task_struct *tsk = cpu == dst_cpu ? p : NULL;
> + unsigned long cpu_util;
> +
> + if (cpu == dst_cpu)
> + util_running += task_util_est();
>
> /*
> * Busy time computation: utilization clamping is not
> @@ -6543,7 +6548,7 @@ compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
> * is already enough to scale the EM reported power
> * consumption at the (eventually clamped) cpu_capacity.
> */
> - sum_util += schedutil_cpu_util(cpu, util_cfs, cpu_cap,
> + sum_util += schedutil_cpu_util(cpu, util_running, cpu_cap,
> ENERGY_UTIL, NULL);
>
> /*
> @@ -6553,7 +6558,7 @@ compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
> * NOTE: in case RT tasks are running, by default the
> * FREQUENCY_UTIL's utilization can be max OPP.
> */
> - cpu_util = schedutil_cpu_util(cpu, util_cfs, cpu_cap,
> + cpu_util = schedutil_cpu_util(cpu, util_freq, cpu_cap,
> FREQUENCY_UTIL, tsk);
> max_util = max(max_util, cpu_util);
> }
>
next prev parent reply other threads:[~2021-02-22 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:54 vincent.donnefort
2021-02-22 10:11 ` Quentin Perret
2021-02-22 11:36 ` Vincent Donnefort
2021-02-22 12:23 ` Quentin Perret
2021-02-22 15:01 ` Vincent Donnefort
2021-02-22 15:58 ` Quentin Perret
2021-02-22 16:23 ` Quentin Perret
2021-02-22 16:39 ` Vincent Donnefort [this message]
2021-02-22 16:43 ` Quentin Perret
2021-02-23 14:47 ` Dietmar Eggemann
2021-02-22 16:31 ` Vincent Donnefort
2021-02-22 16:35 ` Quentin Perret
2021-02-23 14:44 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222163947.GB225035@e124901.cambridge.arm.com \
--to=vincent.donnefort@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®