From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: vincent.donnefort@arm.com, peterz@infradead.org,
mingo@redhat.com, vincent.guittot@linaro.org
Cc: linux-kernel@vger.kernel.org, qperret@google.com,
patrick.bellasi@matbug.net, valentin.schneider@arm.com
Subject: Re: [PATCH] sched/fair: Fix task utilization accountability in cpu_util_next()
Date: Tue, 23 Feb 2021 15:44:41 +0100 [thread overview]
Message-ID: <66a16cf1-ffc5-2a40-7e04-900cc0e2ee2c@arm.com> (raw)
In-Reply-To: <20210222095401.37158-1-vincent.donnefort@arm.com>
On 22/02/2021 10:54, vincent.donnefort@arm.com wrote:
> From: Vincent Donnefort <vincent.donnefort@arm.com>
[...]
> Also, replace sub_positive with lsub_positive which saves one explicit
> load-store.
IMHO, in case you're going to fix this now in compute_energy(), this
optimization could still be done. Maybe in an extra patch?
cpu_util_without() is using lsub_positive() to remove task util from cpu
util as well.
[...]
prev parent reply other threads:[~2021-02-23 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:54 vincent.donnefort
2021-02-22 10:11 ` Quentin Perret
2021-02-22 11:36 ` Vincent Donnefort
2021-02-22 12:23 ` Quentin Perret
2021-02-22 15:01 ` Vincent Donnefort
2021-02-22 15:58 ` Quentin Perret
2021-02-22 16:23 ` Quentin Perret
2021-02-22 16:39 ` Vincent Donnefort
2021-02-22 16:43 ` Quentin Perret
2021-02-23 14:47 ` Dietmar Eggemann
2021-02-22 16:31 ` Vincent Donnefort
2021-02-22 16:35 ` Quentin Perret
2021-02-23 14:44 ` Dietmar Eggemann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a16cf1-ffc5-2a40-7e04-900cc0e2ee2c@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®