* [PATCH] mm: delete bool "migrated"
@ 2021-03-01 12:57 Wang Qing
2021-03-02 23:55 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Wang Qing @ 2021-03-01 12:57 UTC (permalink / raw)
To: Andrew Morton, linux-mm, linux-kernel; +Cc: Wang Qing
Smatch gives the warning:
do_numa_page() warn: assigning (-11) to unsigned variable 'migrated'
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
mm/memory.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 784249f..d8125df
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -4102,7 +4102,6 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf)
int page_nid = NUMA_NO_NODE;
int last_cpupid;
int target_nid;
- bool migrated = false;
pte_t pte, old_pte;
bool was_writable = pte_savedwrite(vmf->orig_pte);
int flags = 0;
@@ -4172,8 +4171,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf)
}
/* Migrate to the requested node */
- migrated = migrate_misplaced_page(page, vma, target_nid);
- if (migrated) {
+ if (migrate_misplaced_page(page, vma, target_nid)) {
page_nid = target_nid;
flags |= TNF_MIGRATED;
} else
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm: delete bool "migrated"
2021-03-01 12:57 [PATCH] mm: delete bool "migrated" Wang Qing
@ 2021-03-02 23:55 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2021-03-02 23:55 UTC (permalink / raw)
To: Wang Qing; +Cc: linux-mm, linux-kernel
On Mon, 1 Mar 2021 20:57:01 +0800 Wang Qing <wangqing@vivo.com> wrote:
> Smatch gives the warning:
> do_numa_page() warn: assigning (-11) to unsigned variable 'migrated'
>
> ...
>
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -4102,7 +4102,6 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf)
> int page_nid = NUMA_NO_NODE;
> int last_cpupid;
> int target_nid;
> - bool migrated = false;
> pte_t pte, old_pte;
> bool was_writable = pte_savedwrite(vmf->orig_pte);
> int flags = 0;
> @@ -4172,8 +4171,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf)
> }
>
> /* Migrate to the requested node */
> - migrated = migrate_misplaced_page(page, vma, target_nid);
> - if (migrated) {
> + if (migrate_misplaced_page(page, vma, target_nid)) {
> page_nid = target_nid;
> flags |= TNF_MIGRATED;
> } else
Looks right.
Methinks both migrate_misplaced_page() and numamigrate_isolate_page()
should return bools. (And that their return values should be documented!)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-03 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 12:57 [PATCH] mm: delete bool "migrated" Wang Qing
2021-03-02 23:55 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®