* [PATCH] tasklet: Remove tasklet_kill_immediate
@ 2021-03-06 21:36 Davidlohr Bueso
2021-03-07 5:13 ` Paul E. McKenney
2021-03-16 14:10 ` [tip: irq/core] " tip-bot2 for Davidlohr Bueso
0 siblings, 2 replies; 3+ messages in thread
From: Davidlohr Bueso @ 2021-03-06 21:36 UTC (permalink / raw)
To: tglx; +Cc: paulmck, dave, linux-kernel, Davidlohr Bueso
Ever since RCU was converted to softirq, it has no users.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
include/linux/interrupt.h | 1 -
kernel/softirq.c | 32 --------------------------------
2 files changed, 33 deletions(-)
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 967e25767153..36a2ac6baf9a 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -712,7 +712,6 @@ static inline void tasklet_enable(struct tasklet_struct *t)
}
extern void tasklet_kill(struct tasklet_struct *t);
-extern void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu);
extern void tasklet_init(struct tasklet_struct *t,
void (*func)(unsigned long), unsigned long data);
extern void tasklet_setup(struct tasklet_struct *t,
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 9908ec4a9bfe..8b44ab9a2f69 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -658,38 +658,6 @@ static void run_ksoftirqd(unsigned int cpu)
}
#ifdef CONFIG_HOTPLUG_CPU
-/*
- * tasklet_kill_immediate is called to remove a tasklet which can already be
- * scheduled for execution on @cpu.
- *
- * Unlike tasklet_kill, this function removes the tasklet
- * _immediately_, even if the tasklet is in TASKLET_STATE_SCHED state.
- *
- * When this function is called, @cpu must be in the CPU_DEAD state.
- */
-void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu)
-{
- struct tasklet_struct **i;
-
- BUG_ON(cpu_online(cpu));
- BUG_ON(test_bit(TASKLET_STATE_RUN, &t->state));
-
- if (!test_bit(TASKLET_STATE_SCHED, &t->state))
- return;
-
- /* CPU is dead, so no lock needed. */
- for (i = &per_cpu(tasklet_vec, cpu).head; *i; i = &(*i)->next) {
- if (*i == t) {
- *i = t->next;
- /* If this was the tail element, move the tail ptr */
- if (*i == NULL)
- per_cpu(tasklet_vec, cpu).tail = i;
- return;
- }
- }
- BUG();
-}
-
static int takeover_tasklets(unsigned int cpu)
{
/* CPU is dead, so no lock needed. */
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tasklet: Remove tasklet_kill_immediate
2021-03-06 21:36 [PATCH] tasklet: Remove tasklet_kill_immediate Davidlohr Bueso
@ 2021-03-07 5:13 ` Paul E. McKenney
2021-03-16 14:10 ` [tip: irq/core] " tip-bot2 for Davidlohr Bueso
1 sibling, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2021-03-07 5:13 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: tglx, linux-kernel, Davidlohr Bueso
On Sat, Mar 06, 2021 at 01:36:58PM -0800, Davidlohr Bueso wrote:
> Ever since RCU was converted to softirq, it has no users.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
That was a long time ago...
Acked-by: Paul E. McKenney <paulmck@kernel.org>
> ---
> include/linux/interrupt.h | 1 -
> kernel/softirq.c | 32 --------------------------------
> 2 files changed, 33 deletions(-)
>
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index 967e25767153..36a2ac6baf9a 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -712,7 +712,6 @@ static inline void tasklet_enable(struct tasklet_struct *t)
> }
>
> extern void tasklet_kill(struct tasklet_struct *t);
> -extern void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu);
> extern void tasklet_init(struct tasklet_struct *t,
> void (*func)(unsigned long), unsigned long data);
> extern void tasklet_setup(struct tasklet_struct *t,
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index 9908ec4a9bfe..8b44ab9a2f69 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -658,38 +658,6 @@ static void run_ksoftirqd(unsigned int cpu)
> }
>
> #ifdef CONFIG_HOTPLUG_CPU
> -/*
> - * tasklet_kill_immediate is called to remove a tasklet which can already be
> - * scheduled for execution on @cpu.
> - *
> - * Unlike tasklet_kill, this function removes the tasklet
> - * _immediately_, even if the tasklet is in TASKLET_STATE_SCHED state.
> - *
> - * When this function is called, @cpu must be in the CPU_DEAD state.
> - */
> -void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu)
> -{
> - struct tasklet_struct **i;
> -
> - BUG_ON(cpu_online(cpu));
> - BUG_ON(test_bit(TASKLET_STATE_RUN, &t->state));
> -
> - if (!test_bit(TASKLET_STATE_SCHED, &t->state))
> - return;
> -
> - /* CPU is dead, so no lock needed. */
> - for (i = &per_cpu(tasklet_vec, cpu).head; *i; i = &(*i)->next) {
> - if (*i == t) {
> - *i = t->next;
> - /* If this was the tail element, move the tail ptr */
> - if (*i == NULL)
> - per_cpu(tasklet_vec, cpu).tail = i;
> - return;
> - }
> - }
> - BUG();
> -}
> -
> static int takeover_tasklets(unsigned int cpu)
> {
> /* CPU is dead, so no lock needed. */
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: irq/core] tasklet: Remove tasklet_kill_immediate
2021-03-06 21:36 [PATCH] tasklet: Remove tasklet_kill_immediate Davidlohr Bueso
2021-03-07 5:13 ` Paul E. McKenney
@ 2021-03-16 14:10 ` tip-bot2 for Davidlohr Bueso
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Davidlohr Bueso @ 2021-03-16 14:10 UTC (permalink / raw)
To: linux-tip-commits
Cc: Davidlohr Bueso, Thomas Gleixner, Paul E. McKenney, x86,
linux-kernel, maz
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 3a0ade0c521a542f8a25e96ce8ea0dfaa532ac75
Gitweb: https://git.kernel.org/tip/3a0ade0c521a542f8a25e96ce8ea0dfaa532ac75
Author: Davidlohr Bueso <dave@stgolabs.net>
AuthorDate: Sat, 06 Mar 2021 13:36:58 -08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 16 Mar 2021 15:06:31 +01:00
tasklet: Remove tasklet_kill_immediate
Ever since RCU was converted to softirq, it has no users.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20210306213658.12862-1-dave@stgolabs.net
---
include/linux/interrupt.h | 1 -
kernel/softirq.c | 32 --------------------------------
2 files changed, 33 deletions(-)
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 76f1161..2b98156 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -716,7 +716,6 @@ static inline void tasklet_enable(struct tasklet_struct *t)
}
extern void tasklet_kill(struct tasklet_struct *t);
-extern void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu);
extern void tasklet_init(struct tasklet_struct *t,
void (*func)(unsigned long), unsigned long data);
extern void tasklet_setup(struct tasklet_struct *t,
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 9908ec4..8b44ab9 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -658,38 +658,6 @@ static void run_ksoftirqd(unsigned int cpu)
}
#ifdef CONFIG_HOTPLUG_CPU
-/*
- * tasklet_kill_immediate is called to remove a tasklet which can already be
- * scheduled for execution on @cpu.
- *
- * Unlike tasklet_kill, this function removes the tasklet
- * _immediately_, even if the tasklet is in TASKLET_STATE_SCHED state.
- *
- * When this function is called, @cpu must be in the CPU_DEAD state.
- */
-void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu)
-{
- struct tasklet_struct **i;
-
- BUG_ON(cpu_online(cpu));
- BUG_ON(test_bit(TASKLET_STATE_RUN, &t->state));
-
- if (!test_bit(TASKLET_STATE_SCHED, &t->state))
- return;
-
- /* CPU is dead, so no lock needed. */
- for (i = &per_cpu(tasklet_vec, cpu).head; *i; i = &(*i)->next) {
- if (*i == t) {
- *i = t->next;
- /* If this was the tail element, move the tail ptr */
- if (*i == NULL)
- per_cpu(tasklet_vec, cpu).tail = i;
- return;
- }
- }
- BUG();
-}
-
static int takeover_tasklets(unsigned int cpu)
{
/* CPU is dead, so no lock needed. */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-16 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-06 21:36 [PATCH] tasklet: Remove tasklet_kill_immediate Davidlohr Bueso
2021-03-07 5:13 ` Paul E. McKenney
2021-03-16 14:10 ` [tip: irq/core] " tip-bot2 for Davidlohr Bueso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®