* [PATCH net] net: phy: broadcom: Fix RGMII delays for BCM50160 and BCM50610M
@ 2021-03-12 0:52 Florian Fainelli
0 siblings, 0 replies; only message in thread
From: Florian Fainelli @ 2021-03-12 0:52 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Andrew Lunn, Heiner Kallweit, Russell King,
David S. Miller, Jakub Kicinski, Abhishek Shah,
open list:BROADCOM ETHERNET PHY DRIVERS, open list
The PHY driver entry for BCM50160 and BCM50610M calls
bcm54xx_config_init() but does not call bcm54xx_config_clock_delay() in
order to configuration appropriate clock delays on the PHY, fix that.
Fixes: 733336262b28 ("net: phy: Allow BCM5481x PHYs to setup internal TX/RX clock delay")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Hi,
More (all) PHY entries that support RGMII should arguably do the same
thing here but given that we had a bad history of seeing broken
DTS/DTBs, I prefer to take a conservative approach here and submit a
localized fix to the hardware I just had to test this on.
While this dates back to before the commit in Fixes tag, that commit
introduces the bcm54xx_config_clock_delay() function and would make it
go far enough for stable back ports.
drivers/net/phy/broadcom.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index fa0be591ae79..4c2f8bb51eef 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -342,6 +342,10 @@ static int bcm54xx_config_init(struct phy_device *phydev)
bcm54xx_adjust_rxrefclk(phydev);
switch (BRCM_PHY_MODEL(phydev)) {
+ case PHY_ID_BCM50610:
+ case PHY_ID_BCM50610M:
+ err = bcm54xx_config_clock_delay(phydev);
+ break;
case PHY_ID_BCM54210E:
err = bcm54210e_config_init(phydev);
break;
--
2.25.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-12 0:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 0:52 [PATCH net] net: phy: broadcom: Fix RGMII delays for BCM50160 and BCM50610M Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®