From: Alexander Lobakin <alobakin@pm.me>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Alexander Lobakin <alobakin@pm.me>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Leon Romanovsky <leon@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 1/4] gro: make net/gro.h self-contained
Date: Thu, 18 Mar 2021 18:42:23 +0000 [thread overview]
Message-ID: <20210318184157.700604-2-alobakin@pm.me> (raw)
In-Reply-To: <20210318184157.700604-1-alobakin@pm.me>
If some source file includes <net/gro.h>, but doesn't include
<linux/indirect_call_wrapper.h>:
In file included from net/8021q/vlan_core.c:7:
./include/net/gro.h:6:1: warning: data definition has no type or storage class
6 | INDIRECT_CALLABLE_DECLARE(struct sk_buff *ipv6_gro_receive(struct list_head *,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
./include/net/gro.h:6:1: error: type defaults to ‘int’ in declaration of ‘INDIRECT_CALLABLE_DECLARE’ [-Werror=implicit-int]
[...]
Include <linux/indirect_call_wrapper.h> directly. It's small and
won't pull lots of dependencies.
Also add some incomplete struct declarations to be fully stacked.
Fixes: 04f00ab2275f ("net/core: move gro function declarations to separate header ")
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
include/net/gro.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/net/gro.h b/include/net/gro.h
index 8a6eb5303cc4..27c38b36df16 100644
--- a/include/net/gro.h
+++ b/include/net/gro.h
@@ -3,6 +3,11 @@
#ifndef _NET_IPV6_GRO_H
#define _NET_IPV6_GRO_H
+#include <linux/indirect_call_wrapper.h>
+
+struct list_head;
+struct sk_buff;
+
INDIRECT_CALLABLE_DECLARE(struct sk_buff *ipv6_gro_receive(struct list_head *,
struct sk_buff *));
INDIRECT_CALLABLE_DECLARE(int ipv6_gro_complete(struct sk_buff *, int));
--
2.31.0
next prev parent reply other threads:[~2021-03-18 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 18:42 [PATCH net-next 0/4] net: avoid retpoline overhead on VLAN and TEB GRO Alexander Lobakin
2021-03-18 18:42 ` Alexander Lobakin [this message]
2021-03-18 18:42 ` [PATCH net-next 2/4] gro: add combined call_gro_receive() + INDIRECT_CALL_INET() helper Alexander Lobakin
2021-03-19 10:53 ` Paolo Abeni
2021-03-19 11:13 ` Alexander Lobakin
2021-03-19 11:43 ` Alexander Lobakin
2021-03-19 12:35 ` Paolo Abeni
2021-03-19 12:49 ` Alexander Lobakin
2021-03-18 18:42 ` [PATCH net-next 3/4] vlan/8021q: avoid retpoline overhead on GRO Alexander Lobakin
2021-03-18 18:42 ` [PATCH net-next 4/4] ethernet: avoid retpoline overhead on TEB (GENEVE, NvGRE, VxLAN) GRO Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318184157.700604-2-alobakin@pm.me \
--to=alobakin@pm.me \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ktkhai@virtuozzo.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®