From: Paolo Abeni <pabeni@redhat.com>
To: Alexander Lobakin <alobakin@pm.me>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Leon Romanovsky <leon@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] gro: add combined call_gro_receive() + INDIRECT_CALL_INET() helper
Date: Fri, 19 Mar 2021 13:35:41 +0100 [thread overview]
Message-ID: <5c1fce37033e98e483728ea9879c3cf4ae83aa28.camel@redhat.com> (raw)
In-Reply-To: <20210319114300.108808-1-alobakin@pm.me>
On Fri, 2021-03-19 at 11:43 +0000, Alexander Lobakin wrote:
> I'm not sure if you did it on purpose in commit aaa5d90b395a7
> ("net: use indirect call wrappers at GRO network layer").
> Was that intentional
I must admit that 2y+ later my own intentions are not so clear to me
too;)
> for the sake of more optimized path for the
> kernels with moduled IPv6,
Uhm... no I guess that was more an underlook on my side.
> or I can replace INDIRECT_CALL_INET()
> with INDIRECT_CALL_2() here too?
If that build with IPV6=nmy, I would say yes.
> I want to keep GRO callbacks that
> make use of indirect call wrappers unified.
L4 will still need some special handling as ipv6 udp gro callbacks are
not builtin with CONFIG_IPV6=m :(
Cheers,
Paolo
next prev parent reply other threads:[~2021-03-19 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 18:42 [PATCH net-next 0/4] net: avoid retpoline overhead on VLAN and TEB GRO Alexander Lobakin
2021-03-18 18:42 ` [PATCH net-next 1/4] gro: make net/gro.h self-contained Alexander Lobakin
2021-03-18 18:42 ` [PATCH net-next 2/4] gro: add combined call_gro_receive() + INDIRECT_CALL_INET() helper Alexander Lobakin
2021-03-19 10:53 ` Paolo Abeni
2021-03-19 11:13 ` Alexander Lobakin
2021-03-19 11:43 ` Alexander Lobakin
2021-03-19 12:35 ` Paolo Abeni [this message]
2021-03-19 12:49 ` Alexander Lobakin
2021-03-18 18:42 ` [PATCH net-next 3/4] vlan/8021q: avoid retpoline overhead on GRO Alexander Lobakin
2021-03-18 18:42 ` [PATCH net-next 4/4] ethernet: avoid retpoline overhead on TEB (GENEVE, NvGRE, VxLAN) GRO Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c1fce37033e98e483728ea9879c3cf4ae83aa28.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=alobakin@pm.me \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ktkhai@virtuozzo.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®