* [PATCH] kernel/sched: remove duplicate include in sched.h sched.h
@ 2021-03-04 12:09 menglong8.dong
2021-03-25 1:34 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: menglong8.dong @ 2021-03-04 12:09 UTC (permalink / raw)
To: mingo
Cc: peterz, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, bristot, linux-kernel, Xiong Zhenwu
From: Xiong Zhenwu <xiong.zhenwu@zte.com.cn>
'linux/psi.h' included in 'kernel/sched/sched.h' is duplicated. it also
include in 59th line.
Signed-off-by: Xiong Zhenwu <xiong.zhenwu@zte.com.cn>
---
kernel/sched/sched.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 10a1522b1e30..235d8381f142 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -344,7 +344,6 @@ extern bool dl_cpu_busy(unsigned int cpu);
#ifdef CONFIG_CGROUP_SCHED
#include <linux/cgroup.h>
-#include <linux/psi.h>
struct cfs_rq;
struct rt_rq;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel/sched: remove duplicate include in sched.h sched.h
2021-03-04 12:09 [PATCH] kernel/sched: remove duplicate include in sched.h sched.h menglong8.dong
@ 2021-03-25 1:34 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2021-03-25 1:34 UTC (permalink / raw)
To: menglong8.dong
Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
bsegall, mgorman, bristot, linux-kernel, Xiong Zhenwu
On Thu, 4 Mar 2021 04:09:26 -0800
menglong8.dong@gmail.com wrote:
> From: Xiong Zhenwu <xiong.zhenwu@zte.com.cn>
>
> 'linux/psi.h' included in 'kernel/sched/sched.h' is duplicated. it also
> include in 59th line.
>
Yep, #include <linux/psi.h> is at the top of the file, no need to have
it again in the the CGROUP_SCHED conditional.
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> Signed-off-by: Xiong Zhenwu <xiong.zhenwu@zte.com.cn>
> ---
> kernel/sched/sched.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 10a1522b1e30..235d8381f142 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -344,7 +344,6 @@ extern bool dl_cpu_busy(unsigned int cpu);
> #ifdef CONFIG_CGROUP_SCHED
>
> #include <linux/cgroup.h>
> -#include <linux/psi.h>
>
> struct cfs_rq;
> struct rt_rq;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 1:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 12:09 [PATCH] kernel/sched: remove duplicate include in sched.h sched.h menglong8.dong
2021-03-25 1:34 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®