mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Yang Shen <shenyang39@huawei.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, wangzhou1@hisilicon.com
Subject: Re: [PATCH 4/4] crypto: hisilicon/zip - support new 'sqe' type in Kunpeng930
Date: Fri, 26 Mar 2021 20:14:57 +1100	[thread overview]
Message-ID: <20210326091457.GA1153@gondor.apana.org.au> (raw)
In-Reply-To: <1616139187-63425-5-git-send-email-shenyang39@huawei.com>

On Fri, Mar 19, 2021 at 03:33:07PM +0800, Yang Shen wrote:
>
> +const struct hisi_zip_sqe_ops hisi_zip_ops_v2 = {
> +	.sqe_type		= 0x3,
> +	.fill_addr		= hisi_zip_fill_addr,
> +	.fill_buf_size		= hisi_zip_fill_buf_size,
> +	.fill_buf_type		= hisi_zip_fill_buf_type,
> +	.fill_req_type		= hisi_zip_fill_req_type,
> +	.fill_tag		= hisi_zip_fill_tag_v2,
> +	.fill_sqe_type		= hisi_zip_fill_sqe_type,
> +	.get_tag		= hisi_zip_get_tag_v2,
> +	.get_status		= hisi_zip_get_status,
> +	.get_dstlen		= hisi_zip_get_dstlen,
> +};
> +

This triggers a new warning:

  CHECK   ../drivers/crypto/hisilicon/zip/zip_crypto.c
  ../drivers/crypto/hisilicon/zip/zip_crypto.c:527:31: warning: symbol 'hisi_zip_ops_v1' was not declared. Should it be static?
  ../drivers/crypto/hisilicon/zip/zip_crypto.c:540:31: warning: symbol 'hisi_zip_ops_v2' was not declared. Should it be static?

Please fix.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2021-03-26  9:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  7:33 [PATCH 0/4]crypto: " Yang Shen
2021-03-19  7:33 ` [PATCH 1/4] crypto: hisilicon/zip - adjust functions location Yang Shen
2021-03-19  7:33 ` [PATCH 2/4] crypto: hisilicon/zip - add comments for 'hisi_zip_sqe' Yang Shen
2021-03-19  7:33 ` [PATCH 3/4] crypto: hisilicon/zip - initialize operations about 'sqe' in 'acomp_alg.init' Yang Shen
2021-03-19  7:33 ` [PATCH 4/4] crypto: hisilicon/zip - support new 'sqe' type in Kunpeng930 Yang Shen
2021-03-26  9:14   ` Herbert Xu [this message]
2021-03-27  2:59     ` shenyang (M)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326091457.GA1153@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shenyang39@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®