mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org, mgorman@suse.de, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com,
	joshdon@google.com, valentin.schneider@arm.com
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, greg@kroah.com
Subject: [PATCH 9/9] sched,fair: Alternative sched_slice()
Date: Fri, 26 Mar 2021 11:34:01 +0100	[thread overview]
Message-ID: <20210326103935.444833549@infradead.org> (raw)
In-Reply-To: <20210326103352.603456266@infradead.org>

The current sched_slice() seems to have issues; there's two possible
things that could be improved:

 - the 'nr_running' used for __sched_period() is daft when cgroups are
   considered. Using the RQ wide h_nr_running seems like a much more
   consistent number.

 - (esp) cgroups can slice it real fine, which makes for easy
   over-scheduling, ensure min_gran is what the name says.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 kernel/sched/fair.c     |   15 ++++++++++++++-
 kernel/sched/features.h |    3 +++
 2 files changed, 17 insertions(+), 1 deletion(-)

--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -680,7 +680,16 @@ static u64 __sched_period(unsigned long
  */
 static u64 sched_slice(struct cfs_rq *cfs_rq, struct sched_entity *se)
 {
-	u64 slice = __sched_period(cfs_rq->nr_running + !se->on_rq);
+	unsigned int nr_running = cfs_rq->nr_running;
+	u64 slice;
+
+	if (sched_feat(ALT_PERIOD))
+		nr_running = rq_of(cfs_rq)->cfs.h_nr_running;
+
+	slice = __sched_period(nr_running + !se->on_rq);
+
+	if (sched_feat(BASE_SLICE))
+		slice -= sysctl_sched_min_granularity;
 
 	for_each_sched_entity(se) {
 		struct load_weight *load;
@@ -697,6 +706,10 @@ static u64 sched_slice(struct cfs_rq *cf
 		}
 		slice = __calc_delta(slice, se->load.weight, load);
 	}
+
+	if (sched_feat(BASE_SLICE))
+		slice += sysctl_sched_min_granularity;
+
 	return slice;
 }
 
--- a/kernel/sched/features.h
+++ b/kernel/sched/features.h
@@ -90,3 +90,6 @@ SCHED_FEAT(WA_BIAS, true)
  */
 SCHED_FEAT(UTIL_EST, true)
 SCHED_FEAT(UTIL_EST_FASTUP, true)
+
+SCHED_FEAT(ALT_PERIOD, true)
+SCHED_FEAT(BASE_SLICE, true)



  parent reply	other threads:[~2021-03-26 10:44 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 10:33 [PATCH 0/9] sched: Clean up SCHED_DEBUG Peter Zijlstra
2021-03-26 10:33 ` [PATCH 1/9] sched/numa: Allow runtime enabling/disabling of NUMA balance without SCHED_DEBUG Peter Zijlstra
2021-03-26 10:33 ` [PATCH 2/9] sched: Remove sched_schedstats sysctl out from under SCHED_DEBUG Peter Zijlstra
2021-03-26 10:33 ` [PATCH 3/9] sched: Dont make LATENCYTOP select SCHED_DEBUG Peter Zijlstra
2021-03-26 10:33 ` [PATCH 4/9] sched: Move SCHED_DEBUG to debugfs Peter Zijlstra
2021-03-26 11:06   ` Greg KH
2021-04-07 10:46   ` Valentin Schneider
2021-04-07 12:26     ` Peter Zijlstra
2021-04-07 12:57       ` Valentin Schneider
2021-03-26 10:33 ` [PATCH 5/9] sched,preempt: Move preempt_dynamic to debug.c Peter Zijlstra
2021-03-26 10:33 ` [PATCH 6/9] debugfs: Implement debugfs_create_str() Peter Zijlstra
2021-03-26 11:05   ` Greg KH
2021-03-26 11:18     ` Peter Zijlstra
2021-03-26 11:30       ` Greg KH
2021-03-26 11:38         ` [PATCH v2 " Peter Zijlstra
2021-03-26 12:18           ` Greg KH
2021-03-26 12:53           ` Rasmus Villemoes
2021-03-26 12:57             ` Greg KH
2021-03-26 13:10               ` Rasmus Villemoes
2021-03-26 14:12                 ` Peter Zijlstra
2021-03-26 14:19                   ` Greg KH
2021-03-26 14:22             ` Peter Zijlstra
2021-03-26 14:58               ` Rasmus Villemoes
2021-03-26 15:19                 ` Peter Zijlstra
2021-03-27 10:41                   ` Greg KH
2021-03-26 14:50   ` [PATCH v3 " Peter Zijlstra
2021-03-27 10:42     ` Greg KH
2021-03-27 22:24   ` [PATCH " Al Viro
2021-03-28  0:33     ` Steven Rostedt
2021-03-26 10:33 ` [PATCH 7/9] sched,debug: Convert sysctl sched_domains to debugfs Peter Zijlstra
2021-03-26 13:11   ` Dietmar Eggemann
2021-04-07 10:46   ` Valentin Schneider
2021-04-07 12:18     ` Peter Zijlstra
2021-03-26 10:34 ` [PATCH 8/9] sched: Move /proc/sched_debug " Peter Zijlstra
2021-03-26 11:05   ` Greg KH
2021-03-26 10:34 ` Peter Zijlstra [this message]
2021-03-26 12:08   ` [PATCH 9/9] sched,fair: Alternative sched_slice() Dietmar Eggemann
2021-03-26 14:07     ` Peter Zijlstra
2021-03-26 15:37   ` Vincent Guittot
2021-03-26 18:30     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326103935.444833549@infradead.org \
    --to=peterz@infradead.org \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=greg@kroah.com \
    --cc=joshdon@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®