mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, mgorman@suse.de, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com,
	joshdon@google.com, valentin.schneider@arm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/9] debugfs: Implement debugfs_create_str()
Date: Fri, 26 Mar 2021 13:18:52 +0100	[thread overview]
Message-ID: <YF3RLAYbewYS7vqc@kroah.com> (raw)
In-Reply-To: <YF3Hv5zXb/6lauzs@hirez.programming.kicks-ass.net>

On Fri, Mar 26, 2021 at 12:38:39PM +0100, Peter Zijlstra wrote:
> On Fri, Mar 26, 2021 at 12:30:24PM +0100, Greg KH wrote:
> > Great, change that and limit the size of the string that can be written
> > and it looks good to me, thanks for adding this.
> 
> Here goes..

Great, except one tiny thing:

> + * This function will return a pointer to a dentry if it succeeds.  This
> + * pointer must be passed to the debugfs_remove() function when the file is
> + * to be removed (no automatic cleanup happens if your module is unloaded,
> + * you are responsible here.)  If an error occurs, ERR_PTR(-ERROR) will be
> + * returned.
> + *
> + * NOTE: when writing is enabled it will replace the string, string lifetime is
> + * assumed to be RCU managed.
> + *
> + * If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will
> + * be returned.

Nothing is returned anymore so the top and bottom paragraphs here no
longer apply.

Fix that up and feel free to add:

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

thanks,

greg k-h

  reply	other threads:[~2021-03-26 12:19 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 10:33 [PATCH 0/9] sched: Clean up SCHED_DEBUG Peter Zijlstra
2021-03-26 10:33 ` [PATCH 1/9] sched/numa: Allow runtime enabling/disabling of NUMA balance without SCHED_DEBUG Peter Zijlstra
2021-03-26 10:33 ` [PATCH 2/9] sched: Remove sched_schedstats sysctl out from under SCHED_DEBUG Peter Zijlstra
2021-03-26 10:33 ` [PATCH 3/9] sched: Dont make LATENCYTOP select SCHED_DEBUG Peter Zijlstra
2021-03-26 10:33 ` [PATCH 4/9] sched: Move SCHED_DEBUG to debugfs Peter Zijlstra
2021-03-26 11:06   ` Greg KH
2021-04-07 10:46   ` Valentin Schneider
2021-04-07 12:26     ` Peter Zijlstra
2021-04-07 12:57       ` Valentin Schneider
2021-03-26 10:33 ` [PATCH 5/9] sched,preempt: Move preempt_dynamic to debug.c Peter Zijlstra
2021-03-26 10:33 ` [PATCH 6/9] debugfs: Implement debugfs_create_str() Peter Zijlstra
2021-03-26 11:05   ` Greg KH
2021-03-26 11:18     ` Peter Zijlstra
2021-03-26 11:30       ` Greg KH
2021-03-26 11:38         ` [PATCH v2 " Peter Zijlstra
2021-03-26 12:18           ` Greg KH [this message]
2021-03-26 12:53           ` Rasmus Villemoes
2021-03-26 12:57             ` Greg KH
2021-03-26 13:10               ` Rasmus Villemoes
2021-03-26 14:12                 ` Peter Zijlstra
2021-03-26 14:19                   ` Greg KH
2021-03-26 14:22             ` Peter Zijlstra
2021-03-26 14:58               ` Rasmus Villemoes
2021-03-26 15:19                 ` Peter Zijlstra
2021-03-27 10:41                   ` Greg KH
2021-03-26 14:50   ` [PATCH v3 " Peter Zijlstra
2021-03-27 10:42     ` Greg KH
2021-03-27 22:24   ` [PATCH " Al Viro
2021-03-28  0:33     ` Steven Rostedt
2021-03-26 10:33 ` [PATCH 7/9] sched,debug: Convert sysctl sched_domains to debugfs Peter Zijlstra
2021-03-26 13:11   ` Dietmar Eggemann
2021-04-07 10:46   ` Valentin Schneider
2021-04-07 12:18     ` Peter Zijlstra
2021-03-26 10:34 ` [PATCH 8/9] sched: Move /proc/sched_debug " Peter Zijlstra
2021-03-26 11:05   ` Greg KH
2021-03-26 10:34 ` [PATCH 9/9] sched,fair: Alternative sched_slice() Peter Zijlstra
2021-03-26 12:08   ` Dietmar Eggemann
2021-03-26 14:07     ` Peter Zijlstra
2021-03-26 15:37   ` Vincent Guittot
2021-03-26 18:30     ` Peter Zijlstra
2021-04-12 10:14 [PATCH v2 0/9] sched: Clean up SCHED_DEBUG Peter Zijlstra
2021-04-12 10:14 ` [PATCH v2 6/9] debugfs: Implement debugfs_create_str() Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YF3RLAYbewYS7vqc@kroah.com \
    --to=greg@kroah.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joshdon@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome