mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: ley.foon.tan@intel.com
Cc: linux-kernel@vger.kernel.org, fazilyildiran@gmail.com
Subject: [PATCH] arch: nios2: fix unmet dependency for SERIAL_CORE_CONSOLE
Date: Fri, 26 Mar 2021 14:55:54 -0400	[thread overview]
Message-ID: <20210326185554.30993-1-julianbraha@gmail.com> (raw)

When EARLY_PRINTK is enabled and TTY is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for SERIAL_CORE_CONSOLE
  Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
  Selected by [y]:
  - EARLY_PRINTK [=y]

This is because EARLY_PRINTK selects SERIAL_CORE_CONSOLE
without selecting or depending on TTY, despite
SERIAL_CORE_CONSOLE depending on TTY.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 arch/nios2/Kconfig.debug | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
index a8bc06e96ef5..f453d5c1fd38 100644
--- a/arch/nios2/Kconfig.debug
+++ b/arch/nios2/Kconfig.debug
@@ -3,6 +3,7 @@
 config EARLY_PRINTK
 	bool "Activate early kernel debugging"
 	default y
+	depends on TTY
 	select SERIAL_CORE_CONSOLE
 	help
 	  Enable early printk on console
-- 
2.25.1


             reply	other threads:[~2021-03-26 18:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 18:55 Julian Braha [this message]
2021-03-29  2:15 ` Tan, Ley Foon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326185554.30993-1-julianbraha@gmail.com \
    --to=julianbraha@gmail.com \
    --cc=fazilyildiran@gmail.com \
    --cc=ley.foon.tan@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®