* [PATCH] arch: nios2: fix unmet dependency for SERIAL_CORE_CONSOLE
@ 2021-03-26 18:55 Julian Braha
2021-03-29 2:15 ` Tan, Ley Foon
0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2021-03-26 18:55 UTC (permalink / raw)
To: ley.foon.tan; +Cc: linux-kernel, fazilyildiran
When EARLY_PRINTK is enabled and TTY is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SERIAL_CORE_CONSOLE
Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
Selected by [y]:
- EARLY_PRINTK [=y]
This is because EARLY_PRINTK selects SERIAL_CORE_CONSOLE
without selecting or depending on TTY, despite
SERIAL_CORE_CONSOLE depending on TTY.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
arch/nios2/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
index a8bc06e96ef5..f453d5c1fd38 100644
--- a/arch/nios2/Kconfig.debug
+++ b/arch/nios2/Kconfig.debug
@@ -3,6 +3,7 @@
config EARLY_PRINTK
bool "Activate early kernel debugging"
default y
+ depends on TTY
select SERIAL_CORE_CONSOLE
help
Enable early printk on console
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] arch: nios2: fix unmet dependency for SERIAL_CORE_CONSOLE
2021-03-26 18:55 [PATCH] arch: nios2: fix unmet dependency for SERIAL_CORE_CONSOLE Julian Braha
@ 2021-03-29 2:15 ` Tan, Ley Foon
0 siblings, 0 replies; 2+ messages in thread
From: Tan, Ley Foon @ 2021-03-29 2:15 UTC (permalink / raw)
To: Julian Braha; +Cc: linux-kernel, fazilyildiran
> -----Original Message-----
> From: Julian Braha <julian.braha@gmail.com> On Behalf Of Julian Braha
> Sent: Saturday, March 27, 2021 2:56 AM
> To: Tan, Ley Foon <ley.foon.tan@intel.com>
> Cc: linux-kernel@vger.kernel.org; fazilyildiran@gmail.com
> Subject: [PATCH] arch: nios2: fix unmet dependency for
> SERIAL_CORE_CONSOLE
>
> When EARLY_PRINTK is enabled and TTY is disabled, Kbuild gives the
> following warning:
>
> WARNING: unmet direct dependencies detected for
> SERIAL_CORE_CONSOLE
> Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
> Selected by [y]:
> - EARLY_PRINTK [=y]
>
> This is because EARLY_PRINTK selects SERIAL_CORE_CONSOLE without
> selecting or depending on TTY, despite SERIAL_CORE_CONSOLE depending
> on TTY.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> arch/nios2/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug index
> a8bc06e96ef5..f453d5c1fd38 100644
> --- a/arch/nios2/Kconfig.debug
> +++ b/arch/nios2/Kconfig.debug
> @@ -3,6 +3,7 @@
> config EARLY_PRINTK
> bool "Activate early kernel debugging"
> default y
> + depends on TTY
> select SERIAL_CORE_CONSOLE
> help
> Enable early printk on console
> --
> 2.25.1
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 18:55 [PATCH] arch: nios2: fix unmet dependency for SERIAL_CORE_CONSOLE Julian Braha
2021-03-29 2:15 ` Tan, Ley Foon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®