mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: jic23@kernel.org
Cc: fazilyildiran@gmail.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] drivers: iio: adc: fix unmet dependency on OF
Date: Sat, 27 Mar 2021 23:51:59 -0400	[thread overview]
Message-ID: <20210328035159.47259-1-julianbraha@gmail.com> (raw)

When AD9467 is enabled, and OF is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for ADI_AXI_ADC
 Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
 Selected by [y]:
 - AD9467 [=y] && IIO [=y] && SPI [=y]

This is because AD9467 selects ADI_AXI_ADC
without selecting or depending on OF,
despite ADI_AXI_ADC depending on OF.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/iio/adc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index e0667c4b3c08..7606c9b1630e 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -248,7 +248,7 @@ config AD799X
 
 config AD9467
 	tristate "Analog Devices AD9467 High Speed ADC driver"
-	depends on SPI
+	depends on SPI && OF
 	select ADI_AXI_ADC
 	help
 	  Say yes here to build support for Analog Devices:
-- 
2.25.1


             reply	other threads:[~2021-03-28  3:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28  3:51 Julian Braha [this message]
2021-03-29  6:42 ` Alexandru Ardelean
2021-03-29 11:18   ` Andy Shevchenko
2021-03-29 16:18   ` Julian Braha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210328035159.47259-1-julianbraha@gmail.com \
    --to=julianbraha@gmail.com \
    --cc=fazilyildiran@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®