[PATCH] drivers: iio: adc: fix unmet dependency on OF

[PATCH] drivers: iio: adc: fix unmet dependency on OF

[Julian Braha]

When AD9467 is enabled, and OF is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for ADI_AXI_ADC
 Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
 Selected by [y]:
 - AD9467 [=y] && IIO [=y] && SPI [=y]

This is because AD9467 selects ADI_AXI_ADC
without selecting or depending on OF,
despite ADI_AXI_ADC depending on OF.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/iio/adc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index e0667c4b3c08..7606c9b1630e 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -248,7 +248,7 @@ config AD799X
 
 config AD9467
 	tristate "Analog Devices AD9467 High Speed ADC driver"
-	depends on SPI
+	depends on SPI && OF
 	select ADI_AXI_ADC
 	help
 	  Say yes here to build support for Analog Devices:
-- 
2.25.1

Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF

[Alexandru Ardelean]

On Sun, Mar 28, 2021 at 7:08 AM Julian Braha <julianbraha@gmail.com> wrote:
>
> When AD9467 is enabled, and OF is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for ADI_AXI_ADC
>  Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
>  Selected by [y]:
>  - AD9467 [=y] && IIO [=y] && SPI [=y]
>
> This is because AD9467 selects ADI_AXI_ADC
> without selecting or depending on OF,
> despite ADI_AXI_ADC depending on OF.
>

Hey,

Thanks for the patch.
This should have been fixed a bit differently with patch:
https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/

Can you check if this fixes your setup?

Thanks
Alex

> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>  drivers/iio/adc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index e0667c4b3c08..7606c9b1630e 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -248,7 +248,7 @@ config AD799X
>
>  config AD9467
>         tristate "Analog Devices AD9467 High Speed ADC driver"
> -       depends on SPI
> +       depends on SPI && OF
>         select ADI_AXI_ADC
>         help
>           Say yes here to build support for Analog Devices:
> --
> 2.25.1
>

Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF

[Andy Shevchenko]

On Mon, Mar 29, 2021 at 9:43 AM Alexandru Ardelean
<ardeleanalex@gmail.com> wrote:
> On Sun, Mar 28, 2021 at 7:08 AM Julian Braha <julianbraha@gmail.com> wrote:
> >
> > When AD9467 is enabled, and OF is disabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for ADI_AXI_ADC
> >  Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
> >  Selected by [y]:
> >  - AD9467 [=y] && IIO [=y] && SPI [=y]
> >
> > This is because AD9467 selects ADI_AXI_ADC
> > without selecting or depending on OF,
> > despite ADI_AXI_ADC depending on OF.

> Thanks for the patch.
> This should have been fixed a bit differently with patch:
> https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/
>
> Can you check if this fixes your setup?

I have to add for sake of the clarification that we are trying really
hard to make drivers agnostic to the device tree provider. In such a
case the same driver can work for all existing providers (ACPI, DT,
and board files with use of software nodes).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF

[Julian Braha]

On Monday, March 29, 2021 2:42:12 AM EDT you wrote:
> On Sun, Mar 28, 2021 at 7:08 AM Julian Braha <julianbraha@gmail.com> wrote:
> >
> > When AD9467 is enabled, and OF is disabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for ADI_AXI_ADC
> >  Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
> >  Selected by [y]:
> >  - AD9467 [=y] && IIO [=y] && SPI [=y]
> >
> > This is because AD9467 selects ADI_AXI_ADC
> > without selecting or depending on OF,
> > despite ADI_AXI_ADC depending on OF.
> >
> 
> Hey,
> 
> Thanks for the patch.
> This should have been fixed a bit differently with patch:
> https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/
> 
> Can you check if this fixes your setup?
> 
> Thanks
> Alex
> 
> > Signed-off-by: Julian Braha <julianbraha@gmail.com>
> > ---
> >  drivers/iio/adc/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index e0667c4b3c08..7606c9b1630e 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -248,7 +248,7 @@ config AD799X
> >
> >  config AD9467
> >         tristate "Analog Devices AD9467 High Speed ADC driver"
> > -       depends on SPI
> > +       depends on SPI && OF
> >         select ADI_AXI_ADC
> >         help
> >           Say yes here to build support for Analog Devices:
> > --
> > 2.25.1
> >
> 
Hi Alex,

I can confirm that this works for me. (https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/)

- Julian Braha