mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Guinot <simon.guinot@sequanux.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: gpio-it87: remove unused code
Date: Tue, 6 Apr 2021 10:35:49 +0200	[thread overview]
Message-ID: <20210406083549.GR25703@kw.sim.vm.gnt> (raw)
In-Reply-To: <1617693639-49182-1-git-send-email-jiapeng.chong@linux.alibaba.com>

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
> 
> drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
> [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Acked-by: Simon Guinot <simon.guinot@sequanux.org>

> ---
>  drivers/gpio/gpio-it87.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c
> index 8f1be34..f332341 100644
> --- a/drivers/gpio/gpio-it87.c
> +++ b/drivers/gpio/gpio-it87.c
> @@ -125,14 +125,6 @@ static inline int superio_inw(int reg)
>  	return val;
>  }
>  
> -static inline void superio_outw(int val, int reg)
> -{
> -	outb(reg++, REG);
> -	outb(val >> 8, VAL);
> -	outb(reg, REG);
> -	outb(val, VAL);
> -}
> -
>  static inline void superio_set_mask(int mask, int reg)
>  {
>  	u8 curr_val = superio_inb(reg);
> -- 
> 1.8.3.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-04-06  8:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  7:20 Jiapeng Chong
2021-04-06  8:35 ` Simon Guinot [this message]
2021-04-09 10:04   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210406083549.GR25703@kw.sim.vm.gnt \
    --to=simon.guinot@sequanux.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®