* [PATCH] gpio: gpio-it87: remove unused code
@ 2021-04-06 7:20 Jiapeng Chong
2021-04-06 8:35 ` Simon Guinot
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2021-04-06 7:20 UTC (permalink / raw)
To: linus.walleij; +Cc: bgolaszewski, linux-gpio, linux-kernel, Jiapeng Chong
Fix the following clang warning:
drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
[-Wunused-function].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpio/gpio-it87.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c
index 8f1be34..f332341 100644
--- a/drivers/gpio/gpio-it87.c
+++ b/drivers/gpio/gpio-it87.c
@@ -125,14 +125,6 @@ static inline int superio_inw(int reg)
return val;
}
-static inline void superio_outw(int val, int reg)
-{
- outb(reg++, REG);
- outb(val >> 8, VAL);
- outb(reg, REG);
- outb(val, VAL);
-}
-
static inline void superio_set_mask(int mask, int reg)
{
u8 curr_val = superio_inb(reg);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: gpio-it87: remove unused code
2021-04-06 7:20 [PATCH] gpio: gpio-it87: remove unused code Jiapeng Chong
@ 2021-04-06 8:35 ` Simon Guinot
2021-04-09 10:04 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Simon Guinot @ 2021-04-06 8:35 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linus.walleij, bgolaszewski, linux-gpio, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
> [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Simon Guinot <simon.guinot@sequanux.org>
> ---
> drivers/gpio/gpio-it87.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c
> index 8f1be34..f332341 100644
> --- a/drivers/gpio/gpio-it87.c
> +++ b/drivers/gpio/gpio-it87.c
> @@ -125,14 +125,6 @@ static inline int superio_inw(int reg)
> return val;
> }
>
> -static inline void superio_outw(int val, int reg)
> -{
> - outb(reg++, REG);
> - outb(val >> 8, VAL);
> - outb(reg, REG);
> - outb(val, VAL);
> -}
> -
> static inline void superio_set_mask(int mask, int reg)
> {
> u8 curr_val = superio_inb(reg);
> --
> 1.8.3.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: gpio-it87: remove unused code
2021-04-06 8:35 ` Simon Guinot
@ 2021-04-09 10:04 ` Bartosz Golaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2021-04-09 10:04 UTC (permalink / raw)
To: Simon Guinot; +Cc: Jiapeng Chong, Linus Walleij, linux-gpio, LKML
On Tue, Apr 6, 2021 at 10:35 AM Simon Guinot <simon.guinot@sequanux.org> wrote:
>
> On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote:
> > Fix the following clang warning:
> >
> > drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
> > [-Wunused-function].
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> Acked-by: Simon Guinot <simon.guinot@sequanux.org>
>
> > ---
> > drivers/gpio/gpio-it87.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c
> > index 8f1be34..f332341 100644
> > --- a/drivers/gpio/gpio-it87.c
> > +++ b/drivers/gpio/gpio-it87.c
> > @@ -125,14 +125,6 @@ static inline int superio_inw(int reg)
> > return val;
> > }
> >
> > -static inline void superio_outw(int val, int reg)
> > -{
> > - outb(reg++, REG);
> > - outb(val >> 8, VAL);
> > - outb(reg, REG);
> > - outb(val, VAL);
> > -}
> > -
> > static inline void superio_set_mask(int mask, int reg)
> > {
> > u8 curr_val = superio_inb(reg);
> > --
> > 1.8.3.1
Patch applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-09 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 7:20 [PATCH] gpio: gpio-it87: remove unused code Jiapeng Chong
2021-04-06 8:35 ` Simon Guinot
2021-04-09 10:04 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®