From: Manish Varma <varmam@google.com>
To: Wolfram Sang <wsa@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Manish Varma <varmam@google.com>
Subject: [PATCH v1 2/2] i2c: use "dev-name" device tree property to override device name
Date: Wed, 7 Apr 2021 11:50:39 -0700 [thread overview]
Message-ID: <20210407185039.621248-3-varmam@google.com> (raw)
In-Reply-To: <20210407185039.621248-1-varmam@google.com>
Since the dev_name field of i2c_board_info is not set while instantiating
an I2C device, they are named like <adapter_id>-<device_addr>, unless
they are instantiated through ACPI.
These coded names are less desirable in some situations as they will vary
across systems with different hardware configurations, and even also on
the same system as the adapter_id may change with change in the order
of i2c bus enumeration (i.e. due to device tree modifications).
These device names are further used by other modules like "system wakeup
events framework" to assign the name of wakeup_source. So overall this
causes somewhat difficult to interpret device and wakeup source names,
and hence presents difficulties debuging issues at multiple levels.
This change addresses above mentioned problem by setting dev_name field
based on value assigned to an optional "dev-name" property of device
tree (if present). And as a result of this, i2c_dev_set_name() should now
use the actual device name instead of made up one.
Signed-off-by: Manish Varma <varmam@google.com>
---
drivers/i2c/i2c-core-of.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c
index 3ed74aa4b44b..d7a85a9cc499 100644
--- a/drivers/i2c/i2c-core-of.c
+++ b/drivers/i2c/i2c-core-of.c
@@ -58,6 +58,8 @@ int of_i2c_get_board_info(struct device *dev, struct device_node *node,
if (of_get_property(node, "wakeup-source", NULL))
info->flags |= I2C_CLIENT_WAKE;
+ of_property_read_string(node, "dev-name", &(info->dev_name));
+
return 0;
}
EXPORT_SYMBOL_GPL(of_i2c_get_board_info);
--
2.31.1.295.g9ea45b61b8-goog
prev parent reply other threads:[~2021-04-07 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 18:50 [PATCH v1 0/2] Override device name using DT "dev-name" property Manish Varma
2021-04-07 18:50 ` [PATCH v1 1/2] dt-bindings: i2c: add "dev-name" property to assign specific device name Manish Varma
2021-04-09 18:34 ` Rob Herring
2021-04-19 23:21 ` Manish Varma
2021-04-07 18:50 ` Manish Varma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407185039.621248-3-varmam@google.com \
--to=varmam@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®