mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kbuild: deb-pkg: change the source package name to 'linux'
@ 2021-04-19  7:01 Masahiro Yamada
  2021-04-19 12:33 ` Ben Hutchings
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2021-04-19  7:01 UTC (permalink / raw)
  To: linux-kbuild
  Cc: linux-kernel, Riku Voipio, Ben Hutchings, Masahiro Yamada, Michal Marek

Change the source package name from 'linux-$(KERNELRELEASE)' to 'linux',
which is aligned with the source package from the Debian community.

The filenames will be changed as follows:

[before]
  linux-5.12.0-rc3+_5.12.0-rc3+-1.dsc
  linux-5.12.0-rc3+_5.12.0-rc3+.orig.tar.gz
  linux-5.12.0-rc3+_5.12.0-rc3+-1.diff.gz

[After]
  linux_5.12.0-rc3+-1.dsc
  linux_5.12.0-rc3+.orig.tar.gz
  linux_5.12.0-rc3+-1.diff.gz

Commit 3716001bcb7f ("deb-pkg: add source package") introduced
KDEB_SOURCENAME. If you are unhappy with the default name, you can
override it via KDEB_SOURCENAME.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/Makefile.package | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile.package b/scripts/Makefile.package
index f952fb64789d..c5834a480545 100644
--- a/scripts/Makefile.package
+++ b/scripts/Makefile.package
@@ -25,7 +25,7 @@ include $(srctree)/scripts/Kbuild.include
 
 # Remove hyphens since they have special meaning in RPM filenames
 KERNELPATH := kernel-$(subst -,_,$(KERNELRELEASE))
-KDEB_SOURCENAME ?= linux-$(KERNELRELEASE)
+KDEB_SOURCENAME ?= linux
 KBUILD_PKG_ROOTCMD ?="fakeroot -u"
 export KDEB_SOURCENAME
 # Include only those top-level files that are needed by make, plus the GPL copy
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kbuild: deb-pkg: change the source package name to 'linux'
  2021-04-19  7:01 [PATCH] kbuild: deb-pkg: change the source package name to 'linux' Masahiro Yamada
@ 2021-04-19 12:33 ` Ben Hutchings
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2021-04-19 12:33 UTC (permalink / raw)
  To: Masahiro Yamada, linux-kbuild; +Cc: linux-kernel, Riku Voipio, Michal Marek

[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]

On Mon, 2021-04-19 at 16:01 +0900, Masahiro Yamada wrote:
> Change the source package name from 'linux-$(KERNELRELEASE)' to 'linux',
> which is aligned with the source package from the Debian community.

I would prefer that the source package name is *not* the same, so that
it is clearly distinguished from distribution packages.

Before commit 3716001bcb7f "deb-pkg: add source package" the binary
packages used to claim that the source package was "linux-upstream"
(although no such source package existed).  Could we use that instead?

Ben.

> The filenames will be changed as follows:
> 
> [before]
>   linux-5.12.0-rc3+_5.12.0-rc3+-1.dsc
>   linux-5.12.0-rc3+_5.12.0-rc3+.orig.tar.gz
>   linux-5.12.0-rc3+_5.12.0-rc3+-1.diff.gz
> 
> [After]
>   linux_5.12.0-rc3+-1.dsc
>   linux_5.12.0-rc3+.orig.tar.gz
>   linux_5.12.0-rc3+-1.diff.gz
> 
> Commit 3716001bcb7f ("deb-pkg: add source package") introduced
> KDEB_SOURCENAME. If you are unhappy with the default name, you can
> override it via KDEB_SOURCENAME.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  scripts/Makefile.package | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> index f952fb64789d..c5834a480545 100644
> --- a/scripts/Makefile.package
> +++ b/scripts/Makefile.package
> @@ -25,7 +25,7 @@ include $(srctree)/scripts/Kbuild.include
>  
>  # Remove hyphens since they have special meaning in RPM filenames
>  KERNELPATH := kernel-$(subst -,_,$(KERNELRELEASE))
> -KDEB_SOURCENAME ?= linux-$(KERNELRELEASE)
> +KDEB_SOURCENAME ?= linux
>  KBUILD_PKG_ROOTCMD ?="fakeroot -u"
>  export KDEB_SOURCENAME
>  # Include only those top-level files that are needed by make, plus the GPL copy

-- 
Ben Hutchings
Humour is the best antidote to reality.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-19 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19  7:01 [PATCH] kbuild: deb-pkg: change the source package name to 'linux' Masahiro Yamada
2021-04-19 12:33 ` Ben Hutchings

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®