[PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI

[PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI

[Guenter Roeck]

With CONFIG_ACPI=n and -Werror, 0-day reports:

drivers/iio/humidity/am2315.c:259:36: error:
	'am2315_acpi_id' defined but not used

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/iio/humidity/am2315.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
index 23bc9c784ef4..e876b039c38f 100644
--- a/drivers/iio/humidity/am2315.c
+++ b/drivers/iio/humidity/am2315.c
@@ -256,12 +256,13 @@ static const struct i2c_device_id am2315_i2c_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, am2315_i2c_id);
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id am2315_acpi_id[] = {
 	{"AOS2315", 0},
 	{}
 };
-
 MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
+#endif
 
 static struct i2c_driver am2315_driver = {
 	.driver = {
-- 
2.25.1

Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI

[Andy Shevchenko]

On Tue, May 4, 2021 at 5:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> With CONFIG_ACPI=n and -Werror, 0-day reports:
>
> drivers/iio/humidity/am2315.c:259:36: error:
>         'am2315_acpi_id' defined but not used

...

> +#ifdef CONFIG_ACPI
>  static const struct acpi_device_id am2315_acpi_id[] = {
>         {"AOS2315", 0},

This is a fake ID according to the specification. Do we have any proof
that it's being used in the wild?
If no, I prefer to drop this ID section entirely.

If yes, needs a comment which device is using it (however it may be
out of the scope of this fix).

>         {}
>  };
> -
>  MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> +#endif

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI

[Andy Shevchenko]

On Tue, May 4, 2021 at 6:11 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, May 4, 2021 at 5:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > With CONFIG_ACPI=n and -Werror, 0-day reports:
> >
> > drivers/iio/humidity/am2315.c:259:36: error:
> >         'am2315_acpi_id' defined but not used
>
> ...
>
> > +#ifdef CONFIG_ACPI
> >  static const struct acpi_device_id am2315_acpi_id[] = {
> >         {"AOS2315", 0},
>
> This is a fake ID according to the specification. Do we have any proof
> that it's being used in the wild?
> If no, I prefer to drop this ID section entirely.
>
> If yes, needs a comment which device is using it (however it may be
> out of the scope of this fix).

Googling shows zarro results.

(Yes, I know about meta-acpi project and I may fix it there, but it
may not be considered as a "being in the wild")

So, please, remove the entire section.

Feel free to add any tag from me (Rb, Ack)

> >         {}
> >  };
> > -
> >  MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> > +#endif


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI

[Guenter Roeck]

Hi Andy,

On Tue, May 04, 2021 at 06:15:44PM +0300, Andy Shevchenko wrote:
> On Tue, May 4, 2021 at 6:11 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Tue, May 4, 2021 at 5:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > >
> > > With CONFIG_ACPI=n and -Werror, 0-day reports:
> > >
> > > drivers/iio/humidity/am2315.c:259:36: error:
> > >         'am2315_acpi_id' defined but not used
> >
> > ...
> >
> > > +#ifdef CONFIG_ACPI
> > >  static const struct acpi_device_id am2315_acpi_id[] = {
> > >         {"AOS2315", 0},
> >
> > This is a fake ID according to the specification. Do we have any proof
> > that it's being used in the wild?
> > If no, I prefer to drop this ID section entirely.
> >
> > If yes, needs a comment which device is using it (however it may be
> > out of the scope of this fix).
> 
> Googling shows zarro results.
> 
> (Yes, I know about meta-acpi project and I may fix it there, but it
> may not be considered as a "being in the wild")
> 
> So, please, remove the entire section.
> 
I'll send v2.

> Feel free to add any tag from me (Rb, Ack)
> 
Since the change is substantial, I don't feel comfortable doing that.
I'll copy you on v2 and let you add the tags yourself.

Thanks,
Guenter

> > >         {}
> > >  };
> > > -
> > >  MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> > > +#endif
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko